[jboss-jira] [JBoss JIRA] (WFCORE-1132) Only set socket send and receive buffer sizes if it is in the Remoting subsystem configuration

[David Lloyd (JIRA)]

    [ https://issues.jboss.org/browse/WFCORE-1132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13128751#comment-13128751 ] 

David Lloyd edited comment on WFCORE-1132 at 11/13/15 9:40 AM:
---------------------------------------------------------------

[~andy.miller] You've made the same mistake that I, Jason, and then Brian made. :-)

The setting in the Remoting schema is about sizing for NIO ByteBuffers used by Remoting.  For this purpose, 8192 is actually an optimal size for these buffers (since they can be filled and emptied using scatter/gather operations).  This value never makes its way to a socket option call.  It maps to RemotingOptions.[SEND|RECEIVE]_BUFFER_SIZE, whereas the socket options come from org.xnio.Options.[SEND_RECEIVE]_BUFFER.  In retrospect I might have chosen less ambiguous names...

But in any event, that schema element is a red herring, and we still have failed to reproduce this problem locally.


was (Author: dmlloyd):
[~anmiller] You've made the same mistake that I, Jason, and then Brian made. :-)

The setting in the Remoting schema is about sizing for NIO ByteBuffers used by Remoting.  For this purpose, 8192 is actually an optimal size for these buffers (since they can be filled and emptied using scatter/gather operations).  This value never makes its way to a socket option call.  It maps to RemotingOptions.[SEND|RECEIVE]_BUFFER_SIZE, whereas the socket options come from org.xnio.Options.[SEND_RECEIVE]_BUFFER.  In retrospect I might have chosen less ambiguous names...

But in any event, that schema element is a red herring, and we still have failed to reproduce this problem locally.

> Only set socket send and receive buffer sizes if it is in the Remoting subsystem configuration
> ----------------------------------------------------------------------------------------------
>
>                 Key: WFCORE-1132
>                 URL: https://issues.jboss.org/browse/WFCORE-1132
>             Project: WildFly Core
>          Issue Type: Bug
>    Affects Versions: 2.0.1.Final
>            Reporter: Andrig Miller
>            Priority: Blocker
>             Fix For: 2.0.2.Final (EAP 7)
>
>
> Original report:
> {quote}
> In our testing of Wildfy 10 CR4, in the performance lab, we found that one of the differences between EAP 6.4.x and Wildfly 10 was that EAP does not set the socket send and receive buffers.  We changed the configuration of Wildfly (Undertow) to remove the buffer parameters from the configuration, and we found that the buffer sizes were still be set to 8k.  We hacked XNIO to comment out the setting of these parameters, and latency improved quite a bit.
> So, we need a permanent fix so that the socket send and receive buffers are only set, if they are specified in the configuration.
> {quote}
> This applies to the Remoting subsystem configuration, versions 2.0 and onwards, and also possibly to Undertow, though that subsystem does not appear to use default values.



--
This message was sent by Atlassian JIRA
(v6.4.11#64026)