[jboss-jira] [JBoss JIRA] (WFLY-4591) Memory leak inPerThreadTagHandlerPool | Wildfly 8.2.0.Final (Undertow)

[Cosmin Stroe (JIRA)]

    [ https://issues.jboss.org/browse/WFLY-4591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13135338#comment-13135338 ] 

Cosmin Stroe commented on WFLY-4591:
------------------------------------

We have ran into the same memory leak in Wildfly 8.2.0.Final, but we are not able to use your attached Jastow JAR, as there are incompatible changes:

{code:java}
^[[0m^[[31m14:27:38,793 ERROR MSC service thread 1-1 [fail] MSC000001: Failed to start service jboss.undertow.deployment.default-server.default-host/syncstorer.UndertowDeploymentInfoService: org.jboss.msc.service.StartException in service jboss.undertow.deployment.default-server.default-host./syncstorer.UndertowDeploymentInfoService: Failed to start service
        at org.jboss.msc.service.ServiceControllerImpl$StartTask.run(ServiceControllerImpl.java:1904)
        at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
        at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
        at java.lang.Thread.run(Thread.java:745)
Caused by: java.lang.NoSuchMethodError: io.undertow.jsp.JspServletBuilder.setupDeployment(Lio/undertow/servlet/api/DeploymentInfo;Ljava/util/HashMap;Ljava/util/HashMap;Lorg/apache/tomcat/InstanceManager;)V
        at org.wildfly.extension.undertow.deployment.UndertowDeploymentInfoService.createServletConfig(UndertowDeploymentInfoService.java:577)
        at org.wildfly.extension.undertow.deployment.UndertowDeploymentInfoService.start(UndertowDeploymentInfoService.java:256)
        at org.jboss.msc.service.ServiceControllerImpl$StartTask.startService(ServiceControllerImpl.java:1948)
        at org.jboss.msc.service.ServiceControllerImpl$StartTask.run(ServiceControllerImpl.java:1881)
        ... 3 more
{code}

How were you able to fix this memory leak?  Is there a workaround?

> Memory leak inPerThreadTagHandlerPool | Wildfly 8.2.0.Final (Undertow)
> ----------------------------------------------------------------------
>
>                 Key: WFLY-4591
>                 URL: https://issues.jboss.org/browse/WFLY-4591
>             Project: WildFly
>          Issue Type: Bug
>          Components: Web (Undertow)
>    Affects Versions: 8.2.0.Final
>         Environment: CentOS release 6.5 (Final), java version "1.7.0_71" 64 bit VM, Wildfly 8.2.0.Final,  Min heap and Max heap 1536m
>  
>            Reporter: Srivathsan Agaram Venkatavaradhan
>            Assignee: Tomaz Cerar
>              Labels: garbage, jastow, undertow, wildfly
>             Fix For: 10.0.0.Alpha3
>
>         Attachments: jastow-2.0.0-SNAPSHOT.jar
>
>
> We upgraded from Jboss 7.1.1.Final to Wildfly 8.2.0.Final. After the upgrade we are seeing full frequent garbage collection (happening every 2 mins)  during load test.  This was not the case in Jboss 7.1.1.Final.  Our heap dumps suggested that there is huge memory leak with 
> org.apache.jasper.runtime.BodyContentImpl.  This is part of JSP runtime (jastow). On analysis we found that undertow uses default as PerThreadTagHanlderPool. By changing this to TagHanlderPool, this issue seems to vanish. 
> diff --git a/src/main/java/org/apache/jasper/runtime/TagHandlerPool.java b/src/main/java/org/apache/jasper/runtime/TagHandlerPool.java
> index eaa8560..c6c785f 100644
> --- a/src/main/java/org/apache/jasper/runtime/TagHandlerPool.java
> +++ b/src/main/java/org/apache/jasper/runtime/TagHandlerPool.java
> @@ -53,7 +53,7 @@ public class TagHandlerPool {
>                  result = null;
>              }
>          }
> -        if( result==null ) result=new PerThreadTagHandlerPool();
> +        if( result==null ) result=new TagHandlerPool();
>          result.init(config);
>  
>          return result;
> - See more at: https://developer.jboss.org/message/927538#927538
> I think this issue may be related to https://issues.jboss.org/browse/WFLY-4617  as there were huge garbage created and most of the contents were char array (rendered html). May be TagHanlderPool is creating more char instead of reusing from pool. Please provide thoughts. I can share, heapdump or MAT screenshots if needed.



--
This message was sent by Atlassian JIRA
(v6.4.11#64026)