[jboss-jira] [JBoss JIRA] (WFLY-5459) Rename JGroups-related attributes

[Jeff Mesnil (JIRA)]

    [ https://issues.jboss.org/browse/WFLY-5459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13114584#comment-13114584 ] 

Jeff Mesnil commented on WFLY-5459:
-----------------------------------

Once WFLY-5189 is fixed, these jgroups-stack and jgroups-channel attributes  should be renamed to reflect their correct semantics.

> Rename JGroups-related attributes
> ---------------------------------
>
>                 Key: WFLY-5459
>                 URL: https://issues.jboss.org/browse/WFLY-5459
>             Project: WildFly
>          Issue Type: Bug
>          Components: JMS
>    Affects Versions: 10.0.0.CR2
>            Reporter: Jeff Mesnil
>            Assignee: Jeff Mesnil
>
> Based on Paul feedback in https://github.com/wildfly/wildfly/pull/8221#issuecomment-145013596:
> {quote}You may want to consider renaming these attributes, however, since the names are now a little confusing. For example, jgroups-stack is perhaps better described as jgroups-channel-factory, since it can specify either a stack name or a channel name. jgroups-channel is also confusing in this context, since this specifies either the cluster name, in the case where jgroups-stack specifies a stack; or the fork name, in the case where the jgroups-stack specifies a channel name. Perhaps jgroups-cluster-name is a better choice?{quote}



--
This message was sent by Atlassian JIRA
(v6.4.11#64026)