[jboss-jira] [JBoss JIRA] (WFCORE-1029) ManagedSocketFactory doesn't work for client sockets

[Dennis Reed (JIRA)]

    [ https://issues.jboss.org/browse/WFCORE-1029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13121281#comment-13121281 ] 

Dennis Reed edited comment on WFCORE-1029 at 10/22/15 10:46 PM:
----------------------------------------------------------------

The exception being triggered is:
java.lang.IllegalStateException
    at org.jboss.as.network.SocketBindingManagerImpl$UnnamedRegistryImpl.registerBinding(SocketBindingManagerImpl.java:471)
    at org.jboss.as.network.SocketBindingManagerImpl$UnnamedRegistryImpl.registerSocket(SocketBindingManagermpl.java:496)
    at org.jboss.as.clustering.jgroups.ManagedSocketFactory.register(ManagedSocketFactory.java:77)
    at org.jboss.as.clustering.jgroups.ManagedSocketFactory.createSocket(ManagedSocketFactory.java:53)

The PR for WFLY-5449 removes the registerSocket call from ManagedSocketFactory, so this is no longer an issue for that use case.  WFCORE-1033 registers the socket in a different spot, and skips the call if it's not bound, resolving this.

Unless .SocketBindingManagerImpl$UnnamedRegistryImpl registry is called from elsewhere in a similar way with unbound sockets, I consider this resolved.



was (Author: dereed):
The exception being triggered is:
java.lang.IllegalStateException
    at org.jboss.as.network.SocketBindingManagerImpl$UnnamedRegistryImpl.registerBinding(SocketBindingManagerImpl.java:471)
    at org.jboss.as.network.SocketBindingManagerImpl$UnnamedRegistryImpl.registerSocket(SocketBindingManagermpl.java:496)
    at org.jboss.as.clustering.jgroups.ManagedSocketFactory.register(ManagedSocketFactory.java:77)
    at org.jboss.as.clustering.jgroups.ManagedSocketFactory.createSocket(ManagedSocketFactory.java:53)

The PR for WFLY-5449 removes the registerSocket call from ManagedSocketFactory, so this is no longer an issue for that use case.  WFCORE-1033 registers the socket in a different spot, and skips the call if it's not bound, resolving this.


> ManagedSocketFactory doesn't work for client sockets
> ----------------------------------------------------
>
>                 Key: WFCORE-1029
>                 URL: https://issues.jboss.org/browse/WFCORE-1029
>             Project: WildFly Core
>          Issue Type: Bug
>          Components: Domain Management
>    Affects Versions: 2.0.0.CR5
>            Reporter: Dennis Reed
>            Assignee: Brian Stansberry
>
> SocketBindingManagerImpl does not work with client sockets.
> It adds sockets to a map based on local address.  Client sockets that have not been bound yet do not have a local address.
> This breaks the JGroups subsystem's ManagedSocketFactory, which uses SocketBindingManagerImpl for both server and client sockets.



--
This message was sent by Atlassian JIRA
(v6.4.11#64026)