[jboss-jira] [JBoss JIRA] (WFLY-5564) Unable to set use-journal-store if use-jdbc-store was set to true before

[Brian Stansberry (JIRA)]

    [ https://issues.jboss.org/browse/WFLY-5564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13122037#comment-13122037 ] 

Brian Stansberry commented on WFLY-5564:
----------------------------------------

Tomas and I had a chat about this issue a week or so ago and I promised to comment here with a few notes just to record publicly what we discussed. Took me a while, but here goes...

First, the "requires" and "alternatives" metadata on attributes is handled by the kernel on the basis of whether an attribute is *defined*, not on the basis of any particular value, e.g. 'true' for a boolean attribute. That means using setAlternatives and setRequires on these 'store' attributes is not good, as it precludes setting values to 'false' without having the automatic verification added in WF 10 (core 2.0) reject requests.

Instead it's better to have the relevant handlers add a step that does custom validation of constraints, e.g. that jdbc-store-datasource must be set if use-jdbc-store is true.

OTOH, in the reverse case there's no logical requirement that use-jdbc-store is true if jdbc-store-datasource is defined. If it's not true that just means the datasource name is cruft. Being lenient about accepting cruft like that has the advantage though of letting users first set the jdbc-store-datasource and then set  use-jdbc-store=true without having to use a batch. So, we'll be lenient.
 
I'll think about enhancing the kernel to handle more sophisticated behavior for alternatives/requires, but that can't and shouldn't block this work.

> Unable to set use-journal-store if use-jdbc-store was set to true before
> ------------------------------------------------------------------------
>
>                 Key: WFLY-5564
>                 URL: https://issues.jboss.org/browse/WFLY-5564
>             Project: WildFly
>          Issue Type: Bug
>          Components: Transactions
>    Affects Versions: 10.0.0.CR3
>         Environment: EAP 7.0.0.DR11
>            Reporter: Jan Kašík
>            Assignee: Tomas Hofman
>
> It is impossible to set use-journal-store or use-jdbc-store after other was set. The other has to have its default value, although setting it back to its default value won't help.



--
This message was sent by Atlassian JIRA
(v6.4.11#64026)