[jboss-jira] [JBoss JIRA] (WFCORE-896) Cannot patch EAP once Docs are excluded from installation

[Alexey Loubyansky (JIRA)]

    [ https://issues.jboss.org/browse/WFCORE-896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13105308#comment-13105308 ] 

Alexey Loubyansky commented on WFCORE-896:
------------------------------------------

With the referenced PR merged, misc content modifications now have an additional attribute called condition. If the attribute is not present then the modification is considered to be required and the patch will be aborted if the modification could not be applied for some reason.
If the modification attribute is present then at application patch the condition will be evaluated and if the condition is satisfied, the modification will be applied, otherwise the modification will simply be skipped w/o aborting the whole patch.
This fix introduced a new patch.xml schema include the new attribute. And the patchgen tool (not tracked here) was also updated to support the generation of patch.xml files that may contain conditions.
The only condition added is the one checking for existence of a file system path relative to the installation root directory.

> Cannot patch EAP once Docs are excluded from installation
> ---------------------------------------------------------
>
>                 Key: WFCORE-896
>                 URL: https://issues.jboss.org/browse/WFCORE-896
>             Project: WildFly Core
>          Issue Type: Bug
>          Components: Patching 
>    Affects Versions: 2.0.0.Beta1
>            Reporter: Petr Kremensky
>            Assignee: Alexey Loubyansky
>            Priority: Blocker
>             Fix For: 2.0.0.CR1
>
>         Attachments: dr8_to_dr8x.zip
>
>
> EAP installer allows user to exclude some packs from installation. Docs directory is one of them. If user choose to do so, $JBOSS_HOME/docs directory is not present in distribution.
> Trying to apply a patch (contains changes with docs files) on such a distribution gives me:
> {noformat}
> java.io.FileNotFoundException: /home/pkremens/workspace/jboss-eap-7.0/docs/schema/saml-schema-authn-context-xmldsig-2.0.xsd (No such file or directory)
> {noformat}
> This could block customers, who are using installer to get EAP, from consuming the patches for CP releases in future.
> Patch was generated using:
> https://github.com/jbossas/patch-gen
> dr8_to_dr8x.zip patch.xml:
> {code:xml}
> <?xml version="1.0" ?>
> <patch xmlns="urn:jboss:patch:1.0" id="dr8_to_dr8x">
>     <description>
>         No description available
>     </description>
>     <upgrade name="EAP" version="7.0.0.Alpha1" to-version="7.0.0.Alpha1"/>
>     <element id="layer-base-dr8_to_dr8x">
>         <description>
>             No description available
>         </description>
>         <upgrade name="base"/>
>     </element>
>     <misc-files>
>         <added path="docs/schema/saml-schema-authn-context-xmldsig-2.1.xsd" hash="25d2e47a02d248101af86cff07daf9d51d8da379"/>
>         <updated path="docs/schema/saml-schema-ecp-2.0.xsd" hash="97984434c30816939c0f64b9388dc75d977a3b17" new-hash="fa7e234444b3c5d9ede81b4799dfaff8632d987a"/>
>         <removed path="docs/schema/saml-schema-authn-context-xmldsig-2.0.xsd" hash="25d2e47a02d248101af86cff07daf9d51d8da379"/>
>     </misc-files>
> </patch>
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.11#64026)