[jboss-jira] [JBoss JIRA] (WFCORE-939) Embedded host controller should set launch type attribute to EMBEDDED

[Brian Stansberry (JIRA)]

    [ https://issues.jboss.org/browse/WFCORE-939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13106500#comment-13106500 ] 

Brian Stansberry commented on WFCORE-939:
-----------------------------------------

Using ServerEnvironment.LaunchType to drive this attribute in the first place was incorrect IMO. If you look at the full use of the enum, it's clearly not related to HC processes.

Using "DOMAIN" for the standard non-embedded case isn't an ideal term, but since that's what we've reported in the past we should stick with that even if we change the enum to something HC-specific.

> Embedded host controller should set launch type attribute to EMBEDDED
> ---------------------------------------------------------------------
>
>                 Key: WFCORE-939
>                 URL: https://issues.jboss.org/browse/WFCORE-939
>             Project: WildFly Core
>          Issue Type: Bug
>          Components: CLI, Domain Management
>    Affects Versions: 2.0.0.Beta4
>            Reporter: Petr Kremensky
>            Assignee: Ken Wills
>
> *DomainRootDefinition.java* always set launch type to {noformat}new LaunchTypeHandler(ServerEnvironment.LaunchType.DOMAIN){noformat} even if the host controller process is embedded. 
> Looking into the LaunchType class, I believe that EMBEDDED value should be used.
> {noformat}
>     /** The manner in which a server can be launched */
>     public static enum LaunchType {
>         /** Launched by a Host Controller in a managed domain */
>         DOMAIN(ProcessType.DOMAIN_SERVER),
>         /** Launched from the command line */
>         STANDALONE(ProcessType.STANDALONE_SERVER),
>         /** Launched by another process in which the server is embedded */
>         EMBEDDED(ProcessType.EMBEDDED_SERVER),
> ...
> {noformat}
> \\
> *Additional info:*
> {noformat}./standalone.sh
> launch-type              STANDALONE
> {noformat}
> {noformat}./domain.sh
> launch-type              DOMAIN
> {noformat}
> {noformat}[disconnected /] embed-server 
> launch-type              EMBEDDED
> {noformat}
> {noformat}[disconnected /] embed-host-controller
> launch-type              DOMAIN
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.4.11#64026)