[jboss-jira] [JBoss JIRA] (WFCORE-1417) org.jboss.as.cli.scriptsupport.CLI connect methods do not properly reset the ctx upon failure making in turn checkNotConnected() to report incorrectly

[Jean-Francois Denise (JIRA)]

     [ https://issues.jboss.org/browse/WFCORE-1417?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jean-Francois Denise reassigned WFCORE-1417:
--------------------------------------------

    Assignee: Jean-Francois Denise  (was: Alexey Loubyansky)


> org.jboss.as.cli.scriptsupport.CLI connect methods do not properly reset the ctx upon failure making in turn checkNotConnected() to report incorrectly
> ------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: WFCORE-1417
>                 URL: https://issues.jboss.org/browse/WFCORE-1417
>             Project: WildFly Core
>          Issue Type: Bug
>          Components: CLI
>    Affects Versions: 2.1.0.CR1
>            Reporter: Tom Fonteyne
>            Assignee: Jean-Francois Denise
>            Priority: Minor
>
> cli/src/main/java/org/jboss/as/cli/scriptsupport/CLI.java
>     public void connect() {
>         checkAlreadyConnected();
>         try {
>             ctx = CommandContextFactory.getInstance().newCommandContext();
>             ctx.connectController();
>         } catch (CliInitializationException e) {
>             throw new IllegalStateException("Unable to initialize command context.", e);
>         } catch (CommandLineException e) {
>             throw new IllegalStateException("Unable to connect to controller.", e);
>         }
>     }
> also applicable to the other connects of course.
> If the connection fails in the connect method, a subsequent connect will hit:
>     private void checkAlreadyConnected() {
>         if (ctx != null) throw new IllegalStateException("Already connected to server.");
>     }
> and will fail for the wrong reason... as while ctx !=null is true, but the connection had failed.
> ergo, upon failure in connect, the ctx should be reset to avoid this



--
This message was sent by Atlassian JIRA
(v6.4.11#64026)