[jboss-jira] [JBoss JIRA] (WFCORE-1471) CLI class is mixing commands and operations

[Jean-Francois Denise (JIRA)]

     [ https://issues.jboss.org/browse/WFCORE-1471?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jean-Francois Denise reassigned WFCORE-1471:
--------------------------------------------

    Description: 
CLI.cmd method logic is not in sync with the CLI syntax. 
A fallback is implemented in order to route requests to cx.handle only if ctx.buildRequest(cliCommand) is failing. 
For example this doesn't cope with reload vs :reload. In this case, buildRequest will succeed both for reload and :reload. CLI.cmd("reload") will end to be treated as CLI.cmd(":reload");

Furthermore batch and workflow are not supported by CLI.

I am suggesting to implement the following logic:
1) If batch is enabled or a workflow is enabled, route the command to handle
2) Parse the request.
3) If this is an operation, route to execute
4) Otherwise route to handle



  was:
Creating and connecting a context although the remote server is not yet up and running has a side effect in this following case:
1) Create a fresh context
2) Embed a server
3) Reload it with management enabled
4) Create another Context and connect to embedded remote interface
==> All is fine
Add a step in between 1) an 2) the create and connect a context to the remote management interface (that obviously is not yet there) and step 3) will fail. Reloading the embedded server fails

The way to reload the embedded server has an impact. context.handle(...) will not be affected, context.getControllerClient().execute(...) is impacted.. So something wrong there to chase.



        Summary: CLI class is mixing commands and operations  (was: Side effect in CommandContext instances when connection to server is failing)
       Assignee: Jean-Francois Denise  (was: Alexey Loubyansky)


> CLI class is mixing commands and operations
> -------------------------------------------
>
>                 Key: WFCORE-1471
>                 URL: https://issues.jboss.org/browse/WFCORE-1471
>             Project: WildFly Core
>          Issue Type: Bug
>          Components: CLI
>    Affects Versions: 3.0.0.Alpha1
>            Reporter: Jean-Francois Denise
>            Assignee: Jean-Francois Denise
>
> CLI.cmd method logic is not in sync with the CLI syntax. 
> A fallback is implemented in order to route requests to cx.handle only if ctx.buildRequest(cliCommand) is failing. 
> For example this doesn't cope with reload vs :reload. In this case, buildRequest will succeed both for reload and :reload. CLI.cmd("reload") will end to be treated as CLI.cmd(":reload");
> Furthermore batch and workflow are not supported by CLI.
> I am suggesting to implement the following logic:
> 1) If batch is enabled or a workflow is enabled, route the command to handle
> 2) Parse the request.
> 3) If this is an operation, route to execute
> 4) Otherwise route to handle



--
This message was sent by Atlassian JIRA
(v6.4.11#64026)