[jboss-jira] [JBoss JIRA] (LOGTOOL-104) FQCN and an import improperly deconflicted - FQCN lost

[David Lloyd (JIRA)]

    [ https://issues.jboss.org/browse/LOGTOOL-104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13193330#comment-13193330 ] 

David Lloyd commented on LOGTOOL-104:
-------------------------------------

I think this is caused either by a bug in the import handling in JDeparser, or a bug in the tooling where the JType is being built from an unqualified String rather than the FQCN string which would in turn prevent the import logic from detecting the conflict.

> FQCN and an import improperly deconflicted - FQCN lost
> ------------------------------------------------------
>
>                 Key: LOGTOOL-104
>                 URL: https://issues.jboss.org/browse/LOGTOOL-104
>             Project: Log Tool
>          Issue Type: Bug
>    Affects Versions: 2.0.1.Final
>            Reporter: Arcadiy Ivanov
>
> Given:
> {code}
> import org.osgi.framework.hooks.service.EventHook;
> @MessageLogger(projectCode = "JBOSGI")
> public interface FrameworkLogger extends BasicLogger {
>     @LogMessage(level = WARN)
>     @Message(id = 11019, value = "Error while calling event hook: %s")
>     void warnErrorWhileCallingEventHook(@Cause Throwable cause, EventHook hook);
>     @LogMessage(level = WARN)
>     @Message(id = 11040, value = "Error while calling bundle event hook: %s")
>     void warnErrorWhileCallingBundleEventHook(@Cause Throwable cause, org.osgi.framework.hooks.bundle.EventHook hook);
> }
> {code}
> Compilation failure:
> {quote}
> ERROR] COMPILATION ERROR : 
> [INFO] -------------------------------------------------------------
> [ERROR] /Users/arcivanov/Documents/src/jbosgi/jbosgi-framework/core/target/generated-sources/annotations/org/jboss/osgi/framework/FrameworkLogger_$logger.java:[26,8] org.jboss.osgi.framework.FrameworkLogger_$logger is not abstract and does not override abstract method warnErrorWhileCallingBundleEventHook(java.lang.Throwable,org.osgi.framework.hooks.bundle.EventHook) in org.jboss.osgi.framework.FrameworkLogger
> [ERROR] /Users/arcivanov/Documents/src/jbosgi/jbosgi-framework/core/target/generated-sources/annotations/org/jboss/osgi/framework/FrameworkLogger_$logger.java:[336,5] method does not override or implement a method from a supertype
> {quote}
> Cause:
> {code}
> import org.osgi.framework.hooks.service.EventHook;
> @Generated(value = "org.jboss.logging.processor.generator.model.MessageLoggerImplementor", date = "2016-04-18T04:40:24-0400")
> public class FrameworkLogger_$logger extends DelegatingBasicLogger implements FrameworkLogger,BasicLogger,Serializable {
>     @Override
>     public final void warnErrorWhileCallingEventHook(final Throwable cause, final EventHook hook) {
>         super.log.logf(FQCN, org.jboss.logging.Logger.Level.WARN, cause, warnErrorWhileCallingEventHook$str(), hook);
>     }
>     @Override
>     public final void warnErrorWhileCallingBundleEventHook(final Throwable cause, final EventHook hook) {
>         super.log.logf(FQCN, org.jboss.logging.Logger.Level.WARN, cause, warnErrorWhileCallingBundleEventHook$str(), hook);
>     }
> }
> {code}
> As you can see the cause of the failure is that {{EventHook}} argument FQCN is lost in the generated {{warnErrorWhileCallingBundleEventHook}}.



--
This message was sent by Atlassian JIRA
(v6.4.11#64026)