[jboss-jira] [JBoss JIRA] (WFLY-5973) org.apache.jasper.runtime.BodyContentImpl memory leaking when using JSTL Simple tag what having body is scriptless

[Nilindra Fernando (JIRA)]

    [ https://issues.jboss.org/browse/WFLY-5973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13196124#comment-13196124 ] 

Nilindra Fernando commented on WFLY-5973:
-----------------------------------------

Have not tested in Wildfly 10 directly. However did checked in WF 9.0.2.Final which bundles jastow-1.1.1.Final.jar and cross checked the applicable fixes available in jastow-2.0.0.Final.jar. 

This is from jastow-2.0.0.Final.jar code. 
{code}
org.apache.jasper.runtime.PageContextImpl.java

  public void release()
  ......
      for (BodyContentImpl body : this.outs) {
        body.recycle();
      }
  ......
{code}

In the above code, the below line is missing, hence this small leak still exists. 
I guess the fix should be; 
{code}
org.apache.jasper.runtime.PageContextImpl.java

  public void release()
  ......
      for (BodyContentImpl body : this.outs) {
        body.recycle();
      }
    this.outs = null;
  ......
{code}

Did few testings around this area and it looks good. Please check and incorporate. 


> org.apache.jasper.runtime.BodyContentImpl memory leaking when using JSTL Simple tag what having body is scriptless
> ------------------------------------------------------------------------------------------------------------------
>
>                 Key: WFLY-5973
>                 URL: https://issues.jboss.org/browse/WFLY-5973
>             Project: WildFly
>          Issue Type: Bug
>          Components: Web (Undertow)
>    Affects Versions: 9.0.2.Final
>            Reporter: Loc Ha
>            Assignee: Tomaz Cerar
>            Priority: Critical
>             Fix For: 10.0.0.CR1
>
>
> -- Create any JSTL Simple tag (SimpleTagSupport) that having body is scriptless
> -- Create a JSP using the Simple tag
> -- Request the JSP multi time
> -- Using visualvm 1.3.8 to monitor the allocations of org.apache.jasper.runtime.BodyContentImpl --> You will see a lot of instance of BodyContentImpl created
> -- Click on Perform GC on VisualVM --> The remainging BodyContentImpl didn't go down to ZERO ---> Leaking memory
> -- Did the same test using Glashfish 4 --> When click on Perform GC --> BodyContentImpl went down to Zero --> No leaking memory.



--
This message was sent by Atlassian JIRA
(v6.4.11#64026)