[jboss-jira] [JBoss JIRA] (WFCORE-1682) Missleading tab completion for edit-batch-line command

[Jean-Francois Denise (JIRA)]

    [ https://issues.jboss.org/browse/WFCORE-1682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13273844#comment-13273844 ] 

Jean-Francois Denise commented on WFCORE-1682:
----------------------------------------------

The side effects of WFCORE-1487 are actually in completion too. There is now a mismatch in the completion logic between indexed and named arguments. 
For example: edit-batch-line --line-number=1 :<TAB>
the completer for the line-number (null) is returned instead of the completer for the line.

- The documentation of the commands have not been updated to reflect that the arguments names can be used (look at connect help for example).

> Missleading tab completion for edit-batch-line command
> ------------------------------------------------------
>
>                 Key: WFCORE-1682
>                 URL: https://issues.jboss.org/browse/WFCORE-1682
>             Project: WildFly Core
>          Issue Type: Bug
>          Components: CLI
>            Reporter: Petr Kremensky
>            Assignee: Alexey Loubyansky
>
> Tab completion for edit-batch-list command suggest to use --line-number as a command option, but that is not how the command works.
> *command usage*
> {noformat}
> [standalone at localhost:9990 /] batch 
> [standalone at localhost:9990 / #] :read-resource
> [standalone at localhost:9990 / #] list-batch 
> #1 /:read-resource
> [standalone at localhost:9990 / #] edit-batch-line 1 :read-attribute(name=launch-type)
> #1 :read-attribute(name=launch-type)
> [standalone at localhost:9990 / #] list-batch 
> #1 :read-attribute(name=launch-type)
> {noformat}
> *actual*
> {noformat}
> [standalone at localhost:9990 / #] edit-batch-line <TAB>
> [standalone at localhost:9990 / #] edit-batch-line --<TAB>
> --help  --line-number
> [standalone at localhost:9990 / #] edit-batch-line --line-number=1 :read-attribute(name=launch-type)
> Failed to parse line number '--line-number=1': For input string: "--line-number=1"
> {noformat}
> {{--line-number}} shouldn't be offered by tab completion for the command.
> Misleading tab completion ends up with syntax error.
> *expected*
> {noformat}
> [standalone at localhost:9990 / #] edit-batch-line <TAB>
> --help
> {noformat}
> The issue is a regression against EAP 7.0.0 release.



--
This message was sent by Atlassian JIRA
(v6.4.11#64026)