[jboss-jira] [JBoss JIRA] (JGRP-2138) Request.viewChange() implementations should not use View.getMembers()
Bela Ban (JIRA)
issues at jboss.org
Wed Dec 7 05:07:00 EST 2016
[ https://issues.jboss.org/browse/JGRP-2138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13335088#comment-13335088 ]
Bela Ban commented on JGRP-2138:
--------------------------------
OK, extending GenericList<Address> and implementing get(int index) did the job. Now getMembers() returns this and therefore we have _no_ copying at all...
> Request.viewChange() implementations should not use View.getMembers()
> ---------------------------------------------------------------------
>
> Key: JGRP-2138
> URL: https://issues.jboss.org/browse/JGRP-2138
> Project: JGroups
> Issue Type: Bug
> Reporter: Dan Berindei
> Assignee: Bela Ban
> Priority: Minor
> Fix For: 3.6.12, 4.0
>
>
> {{Request.viewChange()}} is called once for every request, and {{View.getMembers()}} allocates 2 (small) objects. Both {{UnicastRequest}} and {{GroupRequest}} could use {{View.containsMember()}} instead.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
More information about the jboss-jira
mailing list