[jboss-jira] [JBoss JIRA] (JGRP-2015) DONT_BUNDLE+OOB processing: spurious logging, uncounted rejections, retried executions

[Bela Ban (JIRA)]

    [ https://issues.jboss.org/browse/JGRP-2015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13161570#comment-13161570 ] 

Bela Ban commented on JGRP-2015:
--------------------------------

What's the last point about (spurious logging)?

Your PR changes the logic slightly: when you remove a message tagged as {{OOB|DONT_BUNDLE}} and there is an exception passing it to the thread pool (e.g. because the pool is full), the message will not get delivered and has to be retransmitted, whereas in the old code it would get delivered as part of the batch (*if* the thread pool picked for processing the batch doesn't also throw an exception).

I don't think that's an issue though, so I applied your PR.
Thanks,

> DONT_BUNDLE+OOB processing: spurious logging, uncounted rejections, retried executions
> --------------------------------------------------------------------------------------
>
>                 Key: JGRP-2015
>                 URL: https://issues.jboss.org/browse/JGRP-2015
>             Project: JGroups
>          Issue Type: Bug
>    Affects Versions: 3.6.7
>            Reporter: Radoslav Husar
>            Assignee: Radoslav Husar
>             Fix For: 3.6.8, 4.0
>
>
> It seems to me there are few issues in the new DONT_BUNDLE+OOB processing:
> * messages are not removed from batch when execution fails
> * rejections are not counted to num_rejected_msgs
> * spurious logging per message overfills the log



--
This message was sent by Atlassian JIRA
(v6.4.11#64026)