[jboss-jira] [JBoss JIRA] (WFCORE-1259) Embedded HC started with host-slave.xml does not allow changes as master connection service is not available

[Ken Wills (JIRA)]

     [ https://issues.jboss.org/browse/WFCORE-1259?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ken Wills updated WFCORE-1259:
------------------------------
    Comment: was deleted

(was: The following will allow this change to complete, with some capabilities warnings logged:

diff --git a/host-controller/src/main/java/org/jboss/as/domain/controller/operations/SyncModelOperationHandlerWrapper.java b/host-controller/src/main/java/org/jboss/as/domain/controller/operations/SyncModelOperationHandlerWrapper.java
index 3321e72..28e5bc0 100644
--- a/host-controller/src/main/java/org/jboss/as/domain/controller/operations/SyncModelOperationHandlerWrapper.java
+++ b/host-controller/src/main/java/org/jboss/as/domain/controller/operations/SyncModelOperationHandlerWrapper.java
@@ -43,6 +43,7 @@ import org.jboss.as.controller.OperationFailedException;
 import org.jboss.as.controller.OperationStepHandler;
 import org.jboss.as.controller.PathAddress;
 import org.jboss.as.controller.PathElement;
+import org.jboss.as.controller.ProcessType;
 import org.jboss.as.controller.operations.MultistepUtil;
 import org.jboss.as.controller.registry.OperationEntry;
 import org.jboss.as.controller.registry.Resource;
@@ -127,6 +128,11 @@ public final class SyncModelOperationHandlerWrapper implements OperationStepHand
 
         // Validate references on the new model
         final Resource domain = context.readResourceFromRoot(PathAddress.EMPTY_ADDRESS);
+
+        if (context.getProcessType() == ProcessType.EMBEDDED_HOST_CONTROLLER) {
+            return;
+        }
+
         if (syncWithMaster(domain, hostElement)) {
             final MasterDomainControllerClient masterDomainControllerClient = (MasterDomainControllerClient) context.getServiceRegistry(false).getRequiredService(MasterDomainControllerClient.SERVICE_NAME).getValue();
             // This adds an immediate step to synchronize the model configuration before any other step will be executed
)


> Embedded HC started with host-slave.xml does not allow changes as master connection service is not available
> ------------------------------------------------------------------------------------------------------------
>
>                 Key: WFCORE-1259
>                 URL: https://issues.jboss.org/browse/WFCORE-1259
>             Project: WildFly Core
>          Issue Type: Bug
>            Reporter: Ken Wills
>            Assignee: Ken Wills
>
> # update host-slave.xml - simplify the example
> -<host xmlns="urn:jboss:domain:4.0">
> +<host name="slave" xmlns="urn:jboss:domain:4.0">
> $ ./jboss-cli.sh -Djboss.domain.master.address=127.0.0.1
> [disconnected /] embed-host-controller --host-config=host-slave.xml --std-out=echo
> [domain at embedded /] /host=slave/server-config=server-one:write-attribute(name=socket-binding-port-offset, value=1)
> 2:22:06,003 ERROR [org.jboss.as.controller.management-operation] (AeshProcess: 2) WFLYCTL0013: Operation
> +("write-attribute") failed - address: ([
>     ("host" => "slave"),
>     ("server-config" => "server-one")
> ]): org.jboss.msc.service.ServiceNotFoundException: Service service jboss.domain.controller.connection not found
>         at org.jboss.msc.service.ServiceContainerImpl.getRequiredService(ServiceContainerImpl.java:669)
>         at org.jboss.as.controller.OperationContextImpl$OperationContextServiceRegistry.getRequiredService(OperationCo
> +ntextImpl.java:2208)
>         at org.jboss.as.domain.controller.operations.SyncModelOperationHandlerWrapper.execute(SyncModelOperationHandle
> +rWrapper.java:131)
>         at org.jboss.as.controller.AbstractOperationContext.executeStep(AbstractOperationContext.java:890)
>         at org.jboss.as.controller.AbstractOperationContext.processStages(AbstractOperationContext.java:659)
>         at org.jboss.as.controller.AbstractOperationContext.executeOperation(AbstractOperationContext.java:370)
>         at org.jboss.as.controller.OperationContextImpl.executeOperation(OperationContextImpl.java:1341)
>         at org.jboss.as.controller.ModelControllerImpl.internalExecute(ModelControllerImpl.java:392)
>         at org.jboss.as.controller.ModelControllerImpl.execute(ModelControllerImpl.java:204)
>         at org.jboss.as.controller.ModelControllerImpl$3.execute(ModelControllerImpl.java:659)
>         at org.jboss.as.controller.ModelControllerImpl$3.execute(ModelControllerImpl.java:649)
>         at org.jboss.as.controller.client.helpers.DelegatingModelControllerClient.execute(DelegatingModelControllerCli
> +ent.java:63)
> 	at org.jboss.as.cli.embedded.ThreadContextsModelControllerClient.execute(ThreadContextsModelControllerClient.j
> +ava:59)
>         at org.jboss.as.cli.handlers.OperationRequestHandler.handle(OperationRequestHandler.java:84)
>         at org.jboss.as.cli.impl.CommandContextImpl.handle(CommandContextImpl.java:753)
>         at org.jboss.as.cli.impl.CommandContextImpl.handleSafe(CommandContextImpl.java:799)
>         at org.jboss.as.cli.impl.CommandContextImpl$2.execute(CommandContextImpl.java:412)
>         at org.jboss.aesh.console.AeshProcess.run(AeshProcess.java:53)
>         at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
>         at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
>         at java.lang.Thread.run(Thread.java:745)
> {
>     "outcome" => "failed",
>     "result" => {},
>     "failure-description" => {"host-failure-descriptions" => {"slave" => "WFLYCTL0158: Operation handler failed: org.j
> +boss.msc.service.ServiceNotFoundException: Service service jboss.domain.controller.connection not found"}},
>     "rolled-back" => true
> }



--
This message was sent by Atlassian JIRA
(v6.4.11#64026)