[jboss-jira] [JBoss JIRA] (JGRP-1980) Improve throughput under contention for FlowControl.Credit

[Sanne Grinovero (JIRA)]

    [ https://issues.jboss.org/browse/JGRP-1980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13147426#comment-13147426 ] 

Sanne Grinovero commented on JGRP-1980:
---------------------------------------

This was identified by using the JMH test I shared with you.

To clarify: I didn't mean to suggest that the two methods _decrementIfEnoughCredits_ and _decrementAndGet_ are contending among each other. Just that both are showing contention.

Given your explanation, I guess it's possible that many invocations of _decrementIfEnoughCredits_ are contending among each other. And similarly for the other method.

The contention was quite low though, so I wouldn't consider this a priority at this point. It might become more relevant though if we managed to speed-up other areas..

> Improve throughput under contention for FlowControl.Credit
> ----------------------------------------------------------
>
>                 Key: JGRP-1980
>                 URL: https://issues.jboss.org/browse/JGRP-1980
>             Project: JGroups
>          Issue Type: Enhancement
>    Affects Versions: 3.6.6
>            Reporter: Sanne Grinovero
>            Assignee: Bela Ban
>             Fix For: 3.6.8
>
>
> The methods {{org.jgroups.protocols.FlowControl.Credit.decrementIfEnoughCredits(long, long)}} and {{org.jgroups.protocols.FlowControl.Credit.decrementAndGet(long)}} are contending the locks on class synchronization when stress testing JGroups.
> Wondering if we can think of polishing the implementation, although it looks like challenging.



--
This message was sent by Atlassian JIRA
(v6.4.11#64026)