[jboss-jira] [JBoss JIRA] (JGRP-1980) Improve throughput under contention for FlowControl.Credit

[Bela Ban (JIRA)]

     [ https://issues.jboss.org/browse/JGRP-1980?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bela Ban resolved JGRP-1980.
----------------------------
    Resolution: Partially Completed


Moved a synchronized get() into the if(log.isTraceEnabled()) block.
Other than that, I didn't spot any oppurtunities for improvement... Perhaps replace synchronized with ReentrantLock and Object.wait()/notifyAll() with Condition.await()/signalAl()? Googling for the cost of these didn't reveal any insights...
Feel free to reopen this issue if we see any real contention in flight recorder.

> Improve throughput under contention for FlowControl.Credit
> ----------------------------------------------------------
>
>                 Key: JGRP-1980
>                 URL: https://issues.jboss.org/browse/JGRP-1980
>             Project: JGroups
>          Issue Type: Enhancement
>    Affects Versions: 3.6.6
>            Reporter: Sanne Grinovero
>            Assignee: Bela Ban
>             Fix For: 3.6.8
>
>         Attachments: bla.java
>
>
> The methods {{org.jgroups.protocols.FlowControl.Credit.decrementIfEnoughCredits(long, long)}} and {{org.jgroups.protocols.FlowControl.Credit.decrementAndGet(long)}} are contending the locks on class synchronization when stress testing JGroups.
> Wondering if we can think of polishing the implementation, although it looks like challenging.



--
This message was sent by Atlassian JIRA
(v6.4.11#64026)