[jboss-jira] [JBoss JIRA] (JGRP-2044) RequestCorrelator causes frequent boxing and autoboxing by using a Map<Long, Request>

[Bela Ban (JIRA)]

    [ https://issues.jboss.org/browse/JGRP-2044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13266408#comment-13266408 ] 

Bela Ban edited comment on JGRP-2044 at 7/15/16 12:27 PM:
----------------------------------------------------------

How do you see boxing/unboxing in JFR? And what was the percentage you were seeing?
I've looked into this before in JGRP-1982 and decided against it.
I've changed this in my private branch to use Trove's {{TLongObjectHashMap}}, but this
* introduces a dependency which I don't want and
* {{TLongObjectHashMap}} is not concurrent (as {{ConcurrentHashMap}}, and therefore every access needs to be synchronized, slowing things down


was (Author: belaban):
How do you see boxing/unboxing in JFR?

> RequestCorrelator causes frequent boxing and autoboxing by using a Map<Long,Request>
> ------------------------------------------------------------------------------------
>
>                 Key: JGRP-2044
>                 URL: https://issues.jboss.org/browse/JGRP-2044
>             Project: JGroups
>          Issue Type: Enhancement
>            Reporter: Sanne Grinovero
>            Assignee: Bela Ban
>            Priority: Minor
>             Fix For: 4.0
>
>
> The JFR profiler is highlighting a significant amount of boxing and autoboxing, as the request is is treated as a {{long}} but this is used as an key for the {{Map<Long,Request>}}.
> We could try to either consistently use {{Long}} rather than {{long}}, or even better figure out an optimal data structure to replace the implementation of the Map to not require boxing of the keys.



--
This message was sent by Atlassian JIRA
(v6.4.11#64026)