[jboss-jira] [JBoss JIRA] (WFLY-6850) max-saved-replicated-journal-size is ignored

[Bartosz Baranowski (JIRA)]

     [ https://issues.jboss.org/browse/WFLY-6850?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bartosz Baranowski updated WFLY-6850:
-------------------------------------
    Description:     (was: *Scenario:*
# Configure two EAP servers in replicated HA topology
# On backup set {{max-saved-replicated-journal-size=2}}, {{allow-failback=true}} and {{restart-backup=true}}
# Do sequence: kill live, start live, kill live, start live...

*Expectation:* When number of saved replicated journals exceeds 2, the backup should not be restarted but stopped.

*Actual state:* {{max-saved-replicated-journal-size}} is ignored and backup is not stopped. Number of journals grows ad infinitum.

I think that root cause is in {{SharedNothingLiveActivation}}. In the condition \[1\] there should be OR between !isRestartBackup and check if the number of journals was exceeded.

\[1\]
{code}
//if we have to many backups kept or are not configured to restart just stop, otherwise restart as a backup
if (!replicatedPolicy.getReplicaPolicy().isRestartBackup() && activeMQServer.countNumberOfCopiedJournals() >= replicatedPolicy.getReplicaPolicy().getMaxSavedReplicatedJournalsSize() && replicatedPolicy.getReplicaPolicy().getMaxSavedReplicatedJournalsSize() >= 0) {
    activeMQServer.stop(true);
    ActiveMQServerLogger.LOGGER.stopReplicatedBackupAfterFailback();
}
else {
    activeMQServer.stop(true);
    ActiveMQServerLogger.LOGGER.restartingReplicatedBackupAfterFailback();
    activeMQServer.setHAPolicy(replicatedPolicy.getReplicaPolicy());
    activeMQServer.start();
}
{code})


> max-saved-replicated-journal-size is ignored
> --------------------------------------------
>
>                 Key: WFLY-6850
>                 URL: https://issues.jboss.org/browse/WFLY-6850
>             Project: WildFly
>          Issue Type: Bug
>            Reporter: Bartosz Baranowski
>            Assignee: Clebert Suconic
>            Priority: Critical
>              Labels: downstream_dependency
>




--
This message was sent by Atlassian JIRA
(v6.4.11#64026)