[jboss-jira] [JBoss JIRA] (WFLY-459) javassist should also be exported to Hibernate (native) applications

[Stuart Douglas (JIRA)]

    [ https://issues.jboss.org/browse/WFLY-459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13269637#comment-13269637 ] 

Stuart Douglas commented on WFLY-459:
-------------------------------------

I don't really see how this is a blocker, IMHO it should just be rejected. 

The main problem with the proposed fix is that export="true" breaks jboss-deployment-structure.xml exclusions. Non container managed hibernate deployments are very much an edge case IMHO, and the user can simply add the javassist dep when they add the hibernate one.


> javassist should also be exported to Hibernate (native) applications
> --------------------------------------------------------------------
>
>                 Key: WFLY-459
>                 URL: https://issues.jboss.org/browse/WFLY-459
>             Project: WildFly
>          Issue Type: Task
>          Components: JPA / Hibernate
>            Reporter: Scott Marlow
>            Assignee: Scott Marlow
>            Priority: Blocker
>              Labels: downstream_dependency
>             Fix For: 10.1.0.CR1
>
>
> Originally this jira was to stop exporting the javassist module to JPA deployments but it turns out that is fine to do.  In addition, native Hibernate applications that depend on Hibernate, should also get the javassist dependency.  
> # native Hibernate applications will get the javassist dependency via the application dependency on org.hibernate.
> # container managed JPA applications will get the javassist dependency via org.jboss.as.jpa.processor.JPADependencyProcessor (JPA deployer).
> # container managed JPA applications that embed their own copy of Hibernate jars will also get the javassist dependency via org.jboss.as.jpa.processor.JPADependencyProcessor (JPA deployer).



--
This message was sent by Atlassian JIRA
(v6.4.11#64026)