[jboss-jira] [JBoss JIRA] (WFCORE-1592) PropertiesFileLoader persists entries after deletion

[Ken Wills (JIRA)]

    [ https://issues.jboss.org/browse/WFCORE-1592?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13272478#comment-13272478 ] 

Ken Wills commented on WFCORE-1592:
-----------------------------------

I've checked the web console too, this doesn't appear to use this mechanism for adding users at all. So I think we're good to go.

> PropertiesFileLoader persists entries after deletion
> ----------------------------------------------------
>
>                 Key: WFCORE-1592
>                 URL: https://issues.jboss.org/browse/WFCORE-1592
>             Project: WildFly Core
>          Issue Type: Bug
>          Components: Domain Management
>    Affects Versions: 2.1.0.Final, 2.2.0.CR1, 2.2.0.CR2, 3.0.0.Alpha1
>            Reporter: Max Barkley
>            Assignee: Ken Wills
>             Fix For: 3.0.0.Alpha4, 2.2.0.Final
>
>
> There is a bug in PropertiesFileLoader#persistProperties, specifically [here|https://github.com/wildfly/wildfly-core/blob/master/domain-management/src/main/java/org/jboss/as/domain/management/security/PropertiesFileLoader.java#L230-L238]. Because of the write call in the else block, properties are persisted to the file even after they have been deleted in memory.
> [Here|https://github.com/psiroky/uberfire/blob/2811baeac64805646d3943a096e77cf56d5fdc26/uberfire-extensions/uberfire-security/uberfire-security-management/uberfire-security-management-wildfly/src/main/java/org/uberfire/ext/security/management/wildfly/properties/WildflyUserPropertiesManager.java#L221-L246] is a fixed implementation of persistProperties that we are using as a workaround.



--
This message was sent by Atlassian JIRA
(v6.4.11#64026)