[jboss-jira] [JBoss JIRA] (ELY-615) Improvement for usage of file.mkdirs() in FileSystemSecurityRealm.Identity

[David Lloyd (JIRA)]

     [ https://issues.jboss.org/browse/ELY-615?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

David Lloyd resolved ELY-615.
-----------------------------
    Resolution: Rejected


This one is not a bug, but was deliberate, and the reason is that there are only three possible outcomes to this operation:

# The directory is created - in this case everything is fine
# The directory already exists - in this case everything is still fine
# The directory doesn't exist but can't be created for some reason - in this case the subsequent file operation will fail

Because 2 & 3 cannot be distinguished reliably, it's better to just defer until the filesystem operation.


> Improvement for usage of file.mkdirs() in FileSystemSecurityRealm.Identity
> --------------------------------------------------------------------------
>
>                 Key: ELY-615
>                 URL: https://issues.jboss.org/browse/ELY-615
>             Project: WildFly Elytron
>          Issue Type: Bug
>    Affects Versions: 1.1.0.Beta7
>            Reporter: Ondrej Lukas
>            Assignee: Darran Lofthouse
>            Priority: Minor
>              Labels: static_analysis
>             Fix For: 1.1.0.Beta8
>
>
> There is method {{tempPath()}} in org.wildfly.security.auth.realm.FileSystemSecurityRealm.Identity which uses {{file.mkdirs()}} without checking its return value. It is bad practice to ignore return value of this method (since false means that file has not been created and it can result to any unexpected and confusing failure later).



--
This message was sent by Atlassian JIRA
(v6.4.11#64026)