[jboss-jira] [JBoss JIRA] (LOGTOOL-110) Log Tool generates incorrect annotations
gil cattaneo (JIRA)
issues at jboss.org
Wed Jun 8 20:53:00 EDT 2016
[ https://issues.jboss.org/browse/LOGTOOL-110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13249966#comment-13249966 ]
gil cattaneo edited comment on LOGTOOL-110 at 6/8/16 8:52 PM:
--------------------------------------------------------------
the file generated ReflectionLogger_$logger.java should be (not as the attached file where there are too many Override annotation without sense) as ReflectionLogger_logger.java, I renamed to distinguish them
was (Author: puntogil):
the file generated ReflectionLogger_$logger.java should be (not as the attached file where there are too many Override annotation without sense):
package org.jboss.weld.logging;
import java.io.Serializable;
import java.lang.reflect.Method;
import javax.annotation.Generated;
import org.jboss.logging.BasicLogger;
import org.jboss.logging.DelegatingBasicLogger;
import org.jboss.logging.Logger;
/**
* Warning this class consists of generated code.
*
*/
@Generated(value = "org.jboss.logging.processor.generator.model.MessageLoggerImplementor", date = "2016-06-07T17:45:27+0200")
public class ReflectionLogger_$logger
extends DelegatingBasicLogger
implements Serializable, BasicLogger, ReflectionLogger, WeldLogger
{
private final static long serialVersionUID = 1L;
private final static java.lang.String FQCN = ReflectionLogger_$logger.class.getName();
private final static java.lang.String missingTargetMethodFieldType = "WELD-000604: {0} is not declared @Target(METHOD, FIELD, TYPE). Weld will use this annotation, however this may make the application unportable.";
private final static java.lang.String lifecycleCallbackInterceptorWithInvalidBindingTarget = "WELD-000619: A lifecycle callback interceptor declares an interceptor binding with target other than ElementType.TYPE\n {0}\n Binding: {1}\n Target: {2}";
private final static java.lang.String missingTargetMethodFieldTypeParameterOrTargetMethodTypeOrTargetMethodOrTargetTypeOrTargetField = "WELD-000605: {0} is not declared @Target(METHOD, FIELD, TYPE, PARAMETER), @Target(METHOD, TYPE), @Target(METHOD), @Target(TYPE) or @Target(FIELD). Weld will use this annotation, however this may make the application unportable.";
private final static java.lang.String unableToGetFieldOnDeserialization = "WELD-000612: Unable to deserialize field. Declaring class {0}, field name {1}";
private final static java.lang.String unsafeInstantiationFailed = "WELD-000617: Instantiation through Unsafe of {0} failed";
private final static java.lang.String missingTargetTypeMethodOrTargetType = "WELD-000602: {0} is not declared @Target(TYPE, METHOD) or @Target(TYPE). Weld will use this annotation, however this may make the application unportable.";
private final static java.lang.String incorrectNumberOfAnnotatedParametersMethod = "WELD-000614: Incorrect number of AnnotatedParameters {0} on AnnotatedMethod {1}. AnnotatedMethod has {2} as parameters but should have {3} as parameters";
private final static java.lang.String reflectionfactoryInstantiationFailed = "WELD-000616: Instantiation through ReflectionFactory of {0} failed";
private final static java.lang.String unknownType = "WELD-000623: Unknown type {0}.";
private final static java.lang.String missingRetention = "WELD-000600: {0} is missing @Retention(RUNTIME). Weld will use this annotation, however this may make the application unportable.";
private final static java.lang.String unableToGetConstructorOnDeserialization = "WELD-000610: Unable to deserialize constructor. Declaring class {0}, index {1}";
private final static java.lang.String missingTargetMethodFieldParameterType = "WELD-000620: {0} is not declared @Target(METHOD, FIELD, PARAMETER, TYPE). Weld will use this annotation, however this may make the application unportable.";
private final static java.lang.String invalidInterceptorBindingTargetDeclaration = "WELD-000621: Interceptor binding {0} with @Target defined as {1} should not be applied on interceptor binding {2} with @Target definition: {3}";
private final static java.lang.String catchingDebug = "Catching";
private final static java.lang.String missingTarget = "WELD-000601: {0} is missing @Target. Weld will use this annotation, however this may make the application unportable.";
private final static java.lang.String annotationMapNull = "WELD-000607: annotationMap cannot be null";
private final static java.lang.String unableToGetMethodOnDeserialization = "WELD-000611: Unable to deserialize method. Declaring class {0}, index {1}";
private final static java.lang.String invalidTypeArgumentCombination = "WELD-000624: Invalid type argument combination: {0}; {1}.";
private final static java.lang.String unableToGetParameterName = "WELD-000606: Unable to determine name of parameter";
private final static java.lang.String declaredAnnotationMapNull = "WELD-000608: declaredAnnotationMap cannot be null";
private final static java.lang.String noSuchMethodWrapper = "WELD-000625: Unable to locate method: {0}";
private final static java.lang.String illegalArgumentExceptionOnReflectionInvocation = "WELD-000622: IllegalArgumentException invoking {2} on {1} ({0}) with parameters {3}";
public ReflectionLogger_$logger(final Logger log) {
super(log);
}
public final void missingTargetMethodFieldType(final java.lang.Object param1) {
super.log.logv(FQCN, (org.jboss.logging.Logger.Level.DEBUG), null, missingTargetMethodFieldType$str(), param1);
}
protected java.lang.String missingTargetMethodFieldType$str() {
return missingTargetMethodFieldType;
}
public final void lifecycleCallbackInterceptorWithInvalidBindingTarget(final java.lang.Object interceptor, final java.lang.Object binding, final java.lang.Object elementTypes) {
super.log.logv(FQCN, (org.jboss.logging.Logger.Level.WARN), null, lifecycleCallbackInterceptorWithInvalidBindingTarget$str(), interceptor, binding, elementTypes);
}
protected java.lang.String lifecycleCallbackInterceptorWithInvalidBindingTarget$str() {
return lifecycleCallbackInterceptorWithInvalidBindingTarget;
}
public final void missingTargetMethodFieldTypeParameterOrTargetMethodTypeOrTargetMethodOrTargetTypeOrTargetField(final java.lang.Object param1) {
super.log.logv(FQCN, (org.jboss.logging.Logger.Level.DEBUG), null, missingTargetMethodFieldTypeParameterOrTargetMethodTypeOrTargetMethodOrTargetTypeOrTargetField$str(), param1);
}
protected java.lang.String missingTargetMethodFieldTypeParameterOrTargetMethodTypeOrTargetMethodOrTargetTypeOrTargetField$str() {
return missingTargetMethodFieldTypeParameterOrTargetMethodTypeOrTargetMethodOrTargetTypeOrTargetField;
}
public final org.jboss.weld.exceptions.WeldException unableToGetFieldOnDeserialization(final java.lang.Object param1, final java.lang.Object param2, final java.lang.Throwable cause) {
org.jboss.weld.exceptions.WeldException result = new org.jboss.weld.exceptions.WeldException(java.text.MessageFormat.format(unableToGetFieldOnDeserialization$str(), param1, param2), cause);
java.lang.StackTraceElement[] st = result.getStackTrace();
result.setStackTrace(java.util.Arrays.copyOfRange(st, 1, st.length));
return result;
}
protected java.lang.String unableToGetFieldOnDeserialization$str() {
return unableToGetFieldOnDeserialization;
}
public final org.jboss.weld.exceptions.WeldException unsafeInstantiationFailed(final java.lang.Object param1, final java.lang.Throwable cause) {
org.jboss.weld.exceptions.WeldException result = new org.jboss.weld.exceptions.WeldException(java.text.MessageFormat.format(unsafeInstantiationFailed$str(), param1), cause);
java.lang.StackTraceElement[] st = result.getStackTrace();
result.setStackTrace(java.util.Arrays.copyOfRange(st, 1, st.length));
return result;
}
protected java.lang.String unsafeInstantiationFailed$str() {
return unsafeInstantiationFailed;
}
public final void missingTargetTypeMethodOrTargetType(final java.lang.Object param1) {
super.log.logv(FQCN, (org.jboss.logging.Logger.Level.DEBUG), null, missingTargetTypeMethodOrTargetType$str(), param1);
}
protected java.lang.String missingTargetTypeMethodOrTargetType$str() {
return missingTargetTypeMethodOrTargetType;
}
public final org.jboss.weld.exceptions.DefinitionException incorrectNumberOfAnnotatedParametersMethod(final java.lang.Object param1, final java.lang.Object param2, final java.lang.Object param3, final java.lang.Object param4) {
org.jboss.weld.exceptions.DefinitionException result = new org.jboss.weld.exceptions.DefinitionException(java.text.MessageFormat.format(incorrectNumberOfAnnotatedParametersMethod$str(), param1, param2, param3, param4));
java.lang.StackTraceElement[] st = result.getStackTrace();
result.setStackTrace(java.util.Arrays.copyOfRange(st, 1, st.length));
return result;
}
protected java.lang.String incorrectNumberOfAnnotatedParametersMethod$str() {
return incorrectNumberOfAnnotatedParametersMethod;
}
public final org.jboss.weld.exceptions.WeldException reflectionfactoryInstantiationFailed(final java.lang.Object param1, final java.lang.Throwable cause) {
org.jboss.weld.exceptions.WeldException result = new org.jboss.weld.exceptions.WeldException(java.text.MessageFormat.format(reflectionfactoryInstantiationFailed$str(), param1), cause);
java.lang.StackTraceElement[] st = result.getStackTrace();
result.setStackTrace(java.util.Arrays.copyOfRange(st, 1, st.length));
return result;
}
protected java.lang.String reflectionfactoryInstantiationFailed$str() {
return reflectionfactoryInstantiationFailed;
}
public final org.jboss.weld.exceptions.IllegalArgumentException unknownType(final java.lang.reflect.Type type) {
org.jboss.weld.exceptions.IllegalArgumentException result = new org.jboss.weld.exceptions.IllegalArgumentException(java.text.MessageFormat.format(unknownType$str(), type));
java.lang.StackTraceElement[] st = result.getStackTrace();
result.setStackTrace(java.util.Arrays.copyOfRange(st, 1, st.length));
return result;
}
protected java.lang.String unknownType$str() {
return unknownType;
}
public final void missingRetention(final java.lang.Object param1) {
super.log.logv(FQCN, (org.jboss.logging.Logger.Level.DEBUG), null, missingRetention$str(), param1);
}
protected java.lang.String missingRetention$str() {
return missingRetention;
}
public final org.jboss.weld.exceptions.WeldException unableToGetConstructorOnDeserialization(final java.lang.Object param1, final java.lang.Object param2, final java.lang.Throwable cause) {
org.jboss.weld.exceptions.WeldException result = new org.jboss.weld.exceptions.WeldException(java.text.MessageFormat.format(unableToGetConstructorOnDeserialization$str(), param1, param2), cause);
java.lang.StackTraceElement[] st = result.getStackTrace();
result.setStackTrace(java.util.Arrays.copyOfRange(st, 1, st.length));
return result;
}
protected java.lang.String unableToGetConstructorOnDeserialization$str() {
return unableToGetConstructorOnDeserialization;
}
public final void missingTargetMethodFieldParameterType(final java.lang.Object param1) {
super.log.logv(FQCN, (org.jboss.logging.Logger.Level.DEBUG), null, missingTargetMethodFieldParameterType$str(), param1);
}
protected java.lang.String missingTargetMethodFieldParameterType$str() {
return missingTargetMethodFieldParameterType;
}
public final void invalidInterceptorBindingTargetDeclaration(final java.lang.Object param1, final java.lang.Object param2, final java.lang.Object param3, final java.lang.Object param4) {
super.log.logv(FQCN, (org.jboss.logging.Logger.Level.WARN), null, invalidInterceptorBindingTargetDeclaration$str(), param1, param2, param3, param4);
}
protected java.lang.String invalidInterceptorBindingTargetDeclaration$str() {
return invalidInterceptorBindingTargetDeclaration;
}
public final void catchingDebug(final java.lang.Throwable throwable) {
super.log.logf(FQCN, (org.jboss.logging.Logger.Level.DEBUG), (throwable), catchingDebug$str());
}
protected java.lang.String catchingDebug$str() {
return catchingDebug;
}
public final void missingTarget(final java.lang.Object param1) {
super.log.logv(FQCN, (org.jboss.logging.Logger.Level.DEBUG), null, missingTarget$str(), param1);
}
protected java.lang.String missingTarget$str() {
return missingTarget;
}
public final org.jboss.weld.exceptions.WeldException annotationMapNull() {
org.jboss.weld.exceptions.WeldException result = new org.jboss.weld.exceptions.WeldException(java.lang.String.format(annotationMapNull$str()));
java.lang.StackTraceElement[] st = result.getStackTrace();
result.setStackTrace(java.util.Arrays.copyOfRange(st, 1, st.length));
return result;
}
protected java.lang.String annotationMapNull$str() {
return annotationMapNull;
}
public final org.jboss.weld.exceptions.WeldException unableToGetMethodOnDeserialization(final java.lang.Object param1, final java.lang.Object param2, final java.lang.Throwable cause) {
org.jboss.weld.exceptions.WeldException result = new org.jboss.weld.exceptions.WeldException(java.text.MessageFormat.format(unableToGetMethodOnDeserialization$str(), param1, param2), cause);
java.lang.StackTraceElement[] st = result.getStackTrace();
result.setStackTrace(java.util.Arrays.copyOfRange(st, 1, st.length));
return result;
}
protected java.lang.String unableToGetMethodOnDeserialization$str() {
return unableToGetMethodOnDeserialization;
}
public final org.jboss.weld.exceptions.IllegalArgumentException invalidTypeArgumentCombination(final java.lang.reflect.Type type1, final java.lang.reflect.Type type2) {
org.jboss.weld.exceptions.IllegalArgumentException result = new org.jboss.weld.exceptions.IllegalArgumentException(java.text.MessageFormat.format(invalidTypeArgumentCombination$str(), type1, type2));
java.lang.StackTraceElement[] st = result.getStackTrace();
result.setStackTrace(java.util.Arrays.copyOfRange(st, 1, st.length));
return result;
}
protected java.lang.String invalidTypeArgumentCombination$str() {
return invalidTypeArgumentCombination;
}
public final org.jboss.weld.exceptions.IllegalArgumentException unableToGetParameterName() {
org.jboss.weld.exceptions.IllegalArgumentException result = new org.jboss.weld.exceptions.IllegalArgumentException(java.lang.String.format(unableToGetParameterName$str()));
java.lang.StackTraceElement[] st = result.getStackTrace();
result.setStackTrace(java.util.Arrays.copyOfRange(st, 1, st.length));
return result;
}
protected java.lang.String unableToGetParameterName$str() {
return unableToGetParameterName;
}
public final org.jboss.weld.exceptions.WeldException declaredAnnotationMapNull() {
org.jboss.weld.exceptions.WeldException result = new org.jboss.weld.exceptions.WeldException(java.lang.String.format(declaredAnnotationMapNull$str()));
java.lang.StackTraceElement[] st = result.getStackTrace();
result.setStackTrace(java.util.Arrays.copyOfRange(st, 1, st.length));
return result;
}
protected java.lang.String declaredAnnotationMapNull$str() {
return declaredAnnotationMapNull;
}
public final org.jboss.weld.exceptions.WeldException noSuchMethodWrapper(final NoSuchMethodException cause, final java.lang.String message) {
org.jboss.weld.exceptions.WeldException result = new org.jboss.weld.exceptions.WeldException(java.text.MessageFormat.format(noSuchMethodWrapper$str(), message), cause);
java.lang.StackTraceElement[] st = result.getStackTrace();
result.setStackTrace(java.util.Arrays.copyOfRange(st, 1, st.length));
return result;
}
protected java.lang.String noSuchMethodWrapper$str() {
return noSuchMethodWrapper;
}
public final org.jboss.weld.exceptions.WeldException illegalArgumentExceptionOnReflectionInvocation(final Class clazz, final java.lang.Object instance, final Method method, final java.lang.String parameters, final java.lang.IllegalArgumentException cause) {
org.jboss.weld.exceptions.WeldException result = new org.jboss.weld.exceptions.WeldException(java.text.MessageFormat.format(illegalArgumentExceptionOnReflectionInvocation$str(), clazz, instance, method, parameters), cause);
java.lang.StackTraceElement[] st = result.getStackTrace();
result.setStackTrace(java.util.Arrays.copyOfRange(st, 1, st.length));
return result;
}
protected java.lang.String illegalArgumentExceptionOnReflectionInvocation$str() {
return illegalArgumentExceptionOnReflectionInvocation;
}
}
> Log Tool generates incorrect annotations
> ----------------------------------------
>
> Key: LOGTOOL-110
> URL: https://issues.jboss.org/browse/LOGTOOL-110
> Project: Log Tool
> Issue Type: Bug
> Affects Versions: 2.0.1.Final
> Environment: openjdk version "1.8.0_91"
> OpenJDK Runtime Environment (build 1.8.0_91-b14)
> OpenJDK Server VM (build 25.91-b14, mixed mode)
> Apache Maven 3.3.3
> javax.enterprise:cdi-api:jar:1.2
> javax.inject:javax.inject:jar:1
> org.jboss.weld:weld-api:jar:2.3.Final
> org.jboss.weld:weld-spi:jar:2.3.Final
> org.jboss.classfilewriter:jboss-classfilewriter:jar:1.1.2.Final
> org.jboss.spec.javax.ejb:jboss-ejb-api_3.2_spec:jar:1.0.0.Final
> org.jboss.spec.javax.servlet:jboss-servlet-api_3.1_spec:jar:1.0.0.Final
> org.jboss.spec.javax.transaction:jboss-transaction-api_1.2_spec:jar:1.0.0.Final
> org.jboss.spec.javax.annotation:jboss-annotations-api_1.2_spec:jar:1.0.0.Final
> org.hibernate.javax.persistence:hibernate-jpa-2.1-api:jar:1.0.0.Final
> com.google.guava:guava:jar:18.0
> org.jboss.spec.javax.el:jboss-el-api_3.0_spec:jar:1.0.5.Final
> org.jboss.spec.javax.interceptor:jboss-interceptors-api_1.2_spec:jar:1.0.0.Final
> org.jboss.logging:jboss-logging-processor:jar:2.0.1.Final
> org.jboss.logging:jboss-logging-annotations:jar:2.0.1.Final
> org.jboss.jdeparser:jdeparser:jar:2.0.0.Final
> org.jboss.logging:jboss-logging:jar:3.3.0.Final
> net.sourceforge.findbugs:annotations:jar:1.3.2
> Reporter: gil cattaneo
> Attachments: ReflectionLogger.i18n_locale_COUNTRY_VARIANT.properties, ReflectionLogger_$logger.java, ReflectionLogger_logger.java, ResolutionLogger.i18n.properties, weld-core-build.log
>
>
> Hi
> i catch:
> [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.5.1:compile (default-compile) on project weld-core-impl: Compilation failure: Compilation failure:
> [ERROR] /builddir/build/BUILD/core-2.3.4.Final/impl/target/generated-sources/annotations/org/jboss/weld/logging/ReflectionLogger_$logger.java:[25,8] org.jboss.weld.logging.ReflectionLogger_$logger is not abstract and does not override abstract method illegalArgumentExceptionOnReflectionInvocation(java.lang.Class<?>,java.lang.Object,java.lang.reflect.Method,java.lang.String,java.lang.IllegalArgumentException) in org.jboss.weld.logging.ReflectionLogger
> [ERROR] /builddir/build/BUILD/core-2.3.4.Final/impl/target/generated-sources/annotations/org/jboss/weld/logging/ReflectionLogger_$logger.java:[198,5] method does not override or implement a method from a supertype
> [ERROR] -> [Help 1]
> any ideas?
> thanks in advance
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
More information about the jboss-jira
mailing list