[jboss-jira] [JBoss JIRA] (LOGTOOL-110) Log Tool generates incorrect annotations

[James Perkins (JIRA)]

    [ https://issues.jboss.org/browse/LOGTOOL-110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13250398#comment-13250398 ] 

James Perkins commented on LOGTOOL-110:
---------------------------------------

For some reason the build is resolving the wrong dependencies. The {{org.jboss.logging:jboss-logging-processor:jar:1.1.0.Final}} should use the {{org.jboss.logging:jboss-logging-annotations:jar:1.1.0.Final}} dependency not 2.0.1.Final. The 2.0.1.Final version uses a new version of jdeparser which is where the issue is coming from. It's fixed in newer versions of jdeparser, but there's no release of the logging processor that uses the newer version.

{code:title=build.log snippet}
[DEBUG]    org.jboss.logging:jboss-logging-processor:jar:1.1.0.Final:provided
[DEBUG]       org.jboss.logging:jboss-logging-annotations:jar:2.0.1.Final:provided
[DEBUG]       org.jboss.jdeparser:jdeparser:jar:2.0.0.Final:provided
[DEBUG]    org.jboss.logging:jboss-logging:jar:3.2.1.Final:compile
{code}

{code:title=Dependency Tree from Weld}
[INFO] --- maven-dependency-plugin:2.1:tree (default-cli) @ weld-core-impl ---
[INFO] org.jboss.weld:weld-core-impl:jar:3.0.0-SNAPSHOT
[INFO] +- org.jboss.weld:weld-api:jar:3.0.Alpha19:compile
[INFO] |  \- javax.enterprise:cdi-api:jar:2.0.Alpha4:compile
[INFO] |     \- javax.inject:javax.inject:jar:1:compile
[INFO] +- org.jboss.weld:weld-spi:jar:3.0.Alpha19:compile
[INFO] +- org.jboss.classfilewriter:jboss-classfilewriter:jar:1.1.2.Final:compile
[INFO] +- org.jboss.spec.javax.annotation:jboss-annotations-api_1.2_spec:jar:1.0.0.Final:compile
[INFO] +- org.hibernate.javax.persistence:hibernate-jpa-2.1-api:jar:1.0.0.Final:compile
[INFO] +- org.jboss.spec.javax.el:jboss-el-api_3.0_spec:jar:1.0.0.Alpha1:compile
[INFO] +- org.jboss.spec.javax.interceptor:jboss-interceptors-api_1.2_spec:jar:1.0.0.Final:compile
[INFO] +- org.jboss.logging:jboss-logging-processor:jar:1.1.0.Final:provided
[INFO] |  \- org.jboss.jdeparser:jdeparser:jar:1.0.0.Final:provided
[INFO] +- org.jboss.logging:jboss-logging:jar:3.2.1.Final:compile
[INFO] +- net.sourceforge.findbugs:annotations:jar:1.3.2:compile
[INFO] +- junit:junit:jar:4.12:test
[INFO] |  \- org.hamcrest:hamcrest-core:jar:1.3:test
[INFO] \- org.jboss.logmanager:jboss-logmanager:jar:1.2.2.GA:test
{code}

I don't know much about how Fedora builds/RPM's work, but it looks like it's pulling in bad dependencies.

> Log Tool generates incorrect annotations
> ----------------------------------------
>
>                 Key: LOGTOOL-110
>                 URL: https://issues.jboss.org/browse/LOGTOOL-110
>             Project: Log Tool
>          Issue Type: Bug
>    Affects Versions: 2.0.1.Final
>         Environment: openjdk version "1.8.0_91"
> OpenJDK Runtime Environment (build 1.8.0_91-b14)
> OpenJDK Server VM (build 25.91-b14, mixed mode)
> Apache Maven 3.3.3
> javax.enterprise:cdi-api:jar:1.2
> javax.inject:javax.inject:jar:1
> org.jboss.weld:weld-api:jar:2.3.Final
> org.jboss.weld:weld-spi:jar:2.3.Final
> org.jboss.classfilewriter:jboss-classfilewriter:jar:1.1.2.Final
> org.jboss.spec.javax.ejb:jboss-ejb-api_3.2_spec:jar:1.0.0.Final
> org.jboss.spec.javax.servlet:jboss-servlet-api_3.1_spec:jar:1.0.0.Final
> org.jboss.spec.javax.transaction:jboss-transaction-api_1.2_spec:jar:1.0.0.Final
> org.jboss.spec.javax.annotation:jboss-annotations-api_1.2_spec:jar:1.0.0.Final
> org.hibernate.javax.persistence:hibernate-jpa-2.1-api:jar:1.0.0.Final
> com.google.guava:guava:jar:18.0
> org.jboss.spec.javax.el:jboss-el-api_3.0_spec:jar:1.0.5.Final
> org.jboss.spec.javax.interceptor:jboss-interceptors-api_1.2_spec:jar:1.0.0.Final
> org.jboss.logging:jboss-logging-processor:jar:2.0.1.Final
> org.jboss.logging:jboss-logging-annotations:jar:2.0.1.Final
> org.jboss.jdeparser:jdeparser:jar:2.0.0.Final
> org.jboss.logging:jboss-logging:jar:3.3.0.Final
> net.sourceforge.findbugs:annotations:jar:1.3.2
>            Reporter: gil cattaneo
>         Attachments: ReflectionLogger.i18n_locale_COUNTRY_VARIANT.properties, ReflectionLogger.java, ReflectionLogger_$logger.java, ReflectionLogger_logger.java, ResolutionLogger.i18n.properties, weld-core-build.log
>
>
> Hi
> i catch:
> [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.5.1:compile (default-compile) on project weld-core-impl: Compilation failure: Compilation failure:
> [ERROR] /builddir/build/BUILD/core-2.3.4.Final/impl/target/generated-sources/annotations/org/jboss/weld/logging/ReflectionLogger_$logger.java:[25,8] org.jboss.weld.logging.ReflectionLogger_$logger is not abstract and does not override abstract method illegalArgumentExceptionOnReflectionInvocation(java.lang.Class<?>,java.lang.Object,java.lang.reflect.Method,java.lang.String,java.lang.IllegalArgumentException) in org.jboss.weld.logging.ReflectionLogger
> [ERROR] /builddir/build/BUILD/core-2.3.4.Final/impl/target/generated-sources/annotations/org/jboss/weld/logging/ReflectionLogger_$logger.java:[198,5] method does not override or implement a method from a supertype
> [ERROR] -> [Help 1]
> any ideas?
> thanks in advance



--
This message was sent by Atlassian JIRA
(v6.4.11#64026)