[jboss-jira] [JBoss JIRA] (WFLY-6154) [Migration][WebToUndertow] RemoteAddrValve and RemoteHostValve are incorrectly migrated

[Radoslav Husar (JIRA)]

    [ https://issues.jboss.org/browse/WFLY-6154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13251233#comment-13251233 ] 

Radoslav Husar commented on WFLY-6154:
--------------------------------------

The PR was merged, so it looks like this can be resolved [~ehugonnet]?

> [Migration][WebToUndertow] RemoteAddrValve and RemoteHostValve are incorrectly migrated
> ---------------------------------------------------------------------------------------
>
>                 Key: WFLY-6154
>                 URL: https://issues.jboss.org/browse/WFLY-6154
>             Project: WildFly
>          Issue Type: Bug
>          Components: Web (Undertow)
>    Affects Versions: 10.0.0.Final
>            Reporter: ehsavoie Hugonnet
>            Assignee: ehsavoie Hugonnet
>            Priority: Blocker
>
> When migrating {{RemoteHostValve}} or {{RemoteAddrValve}} which contains multiple allows or denies or contains both as in \[1\], it is migrated incorrectly. In the resulting expression the acl attribute should be in format {{acl=\{'xxx allow', 'yyy deny'\}}}, but instead it results in {{acl='xxx allow, yyy deny'}} which is incorrect and results in exception when doing any request to the server. 
> Marking as critical as that it was migrated incorrectly the customer will not find out during migration but when actually doing request to the server.
> Might be interesting to [~ehugonnet]
> [1]
> {code:xml}
>  <valve name="request-filter" module="org.jboss.as.web" class-name="org.apache.catalina.valves.RemoteAddrValve">
>         <param param-name="deny" param-value="10.0.0.1"/>
>         <param param-name="allow" param-value="127.*"/>
>     </valve>
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.11#64026)