[jboss-jira] [JBoss JIRA] (WFCORE-1427) Add a timeout param to reload op and use it for "graceful reload"

[Brian Stansberry (JIRA)]

    [ https://issues.jboss.org/browse/WFCORE-1427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13256057#comment-13256057 ] 

Brian Stansberry commented on WFCORE-1427:
------------------------------------------

[~yersan] Re: ReloadHandler what you propose makes sense to me.

Perhaps a tweak on that would be in the "catch (IOException e)" block in doHandle. If (cliClient.isConnected() == false) (the missing else case of the existing code) then the server has closed the connection, which means the reload has proceeded, and therefore the suspend is done. So then there is no reason to wait for the suspend.

> Add a timeout param to reload op and use it for "graceful reload"
> -----------------------------------------------------------------
>
>                 Key: WFCORE-1427
>                 URL: https://issues.jboss.org/browse/WFCORE-1427
>             Project: WildFly Core
>          Issue Type: Enhancement
>          Components: CLI, Domain Management
>            Reporter: Brian Stansberry
>            Assignee: Yeray Santana Borges
>
> So instead of
> {code}
> :suspend(20)
> :reload
> {code}
> It's just
> {code}
> :reload(20)
> {code}
> The high level 'reload' command in the CLI should take a --timeout param as well.
> If doing the graceful suspend as part of server side ":reload" handling proves problematic (I haven't looked into it at all before filing this) then a simpler alternative is to only go with the --timeout param on the CLI reload command, and have the CLI implement the graceful behavior internally by first calling :suspend and then :reload. Web console could do the same thing.



--
This message was sent by Atlassian JIRA
(v6.4.11#64026)