[jboss-jira] [JBoss JIRA] (JBJCA-1325) Wrong condition when parsing ironjacamar.rollback_on_fatal_error property

[Martin Simka (JIRA)]

Martin Simka created JBJCA-1325:
-----------------------------------

             Summary: Wrong condition when parsing ironjacamar.rollback_on_fatal_error property
                 Key: JBJCA-1325
                 URL: https://issues.jboss.org/browse/JBJCA-1325
             Project: IronJacamar
          Issue Type: Bug
    Affects Versions: WildFly/IronJacamar 1.3.4.Final
            Reporter: Martin Simka
            Assignee: Stefano Maestri


There is wrong condition in https://github.com/ironjacamar/ironjacamar/blob/1.3/core/src/main/java/org/jboss/jca/core/connectionmanager/listener/TxConnectionListener.java#L180

{code:java}
      value = SecurityActions.getSystemProperty("ironjacamar.rollback_on_fatal_error");
      if (value != null && !value.trim().equals(""))
      {
         if ("true".equalsIgnoreCase(value) || "false".equalsIgnoreCase(value))
         {
            doSetRollbackOnly = Boolean.parseBoolean(value);
         }
         else
         {
            StringTokenizer st = new StringTokenizer(value, ",");
            while (doDelistResource && st.hasMoreTokens()) // <-- should be while (doSetRollbackOnly ...
            {
               if (getPool().getName().equals(st.nextToken()))
                  doSetRollbackOnly = false;
            }
         }
      }
{code}



--
This message was sent by Atlassian JIRA
(v6.4.11#64026)