[jboss-jira] [JBoss JIRA] (WFCORE-43) Clarify the meaning of the 'server-state' and 'host-state' attributes

[Brian Stansberry (JIRA)]

    [ https://issues.jboss.org/browse/WFCORE-43?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13182256#comment-13182256 ] 

Brian Stansberry edited comment on WFCORE-43 at 3/24/16 5:53 PM:
-----------------------------------------------------------------

[~luck3y] 
For (2) how about NORMAL?

For WFCORE-1106 for internal use I ended up need a different enum that covered the same concept and I ended up using 'NORMAL' 

https://github.com/wildfly/wildfly-core/compare/master...bstansberry:WFCORE-1106_2?expand=1#diff-d248887751f69446f325176c7a09abfeR38

That's not definitive or anything; ^^^ is an internal enum and TBH I didn't think that hard about the NORMAL name. ;)

"SYNCHRONIZED" is valid; agree it's a bit heavy though. "IN_SYNC"? Do you like boy bands? Or hearing lots of boy band jokes? ;)

Re: 1) this is the more important question. A simple value like "NORMAL" is only ok if the name of the attribute makes it pretty clear what it is that's normal. So, not 'process-state'. We already have a 'running-mode' for --admin-only vs not.  'run-state' seems too vague too. Brainstorming I come up with 'configuration-sync' but I'm not going to pretend that's good.

Maybe 'configuration-state"? That's still a bit weird but this is all about the state of the runtime with respect to the persistent configuration.

A main goal is to come up with something where if we add some new feature and need to describe some state, we don't get a name conflict again.

Haha, now I remember why this issue is 21 months old!


was (Author: brian.stansberry):
For (2) how about NORMAL?

For WFCORE-1106 for internal use I ended up need a different enum that covered the same concept and I ended up using 'NORMAL' 

https://github.com/wildfly/wildfly-core/compare/master...bstansberry:WFCORE-1106_2?expand=1#diff-d248887751f69446f325176c7a09abfeR38

That's not definitive or anything; ^^^ is an internal enum and TBH I didn't think that hard about the NORMAL name. ;)

"SYNCHRONIZED" is valid; agree it's a bit heavy though. "IN_SYNC"? Do you like boy bands? Or hearing lots of boy band jokes? ;)

Re: 1) this is the more important question. A simple value like "NORMAL" is only ok if the name of the attribute makes it pretty clear what it is that's normal. So, not 'process-state'. We already have a 'running-mode' for --admin-only vs not.  'run-state' seems too vague too. Brainstorming I come up with 'configuration-sync' but I'm not going to pretend that's good.

Maybe 'configuration-state"? That's still a bit weird but this is all about the state of the runtime with respect to the persistent configuration.

A main goal is to come up with something where if we add some new feature and need to describe some state, we don't get a name conflict again.

Haha, now I remember why this issue is 21 months old!

> Clarify the meaning of the 'server-state' and 'host-state' attributes
> ---------------------------------------------------------------------
>
>                 Key: WFCORE-43
>                 URL: https://issues.jboss.org/browse/WFCORE-43
>             Project: WildFly Core
>          Issue Type: Enhancement
>          Components: Domain Management
>            Reporter: Brian Stansberry
>            Assignee: Ken Wills
>             Fix For: 3.0.0.Beta1
>
>
> This JIRA is to implement what I described in the dev list discussion around the various states a server can be in for graceful shutdown (http://lists.jboss.org/pipermail/wildfly-dev/2014-June/002360.html)
> "I do think these are orthogonal and should not be combined.
> The existing attribute is fundamentally about how the state of the 
> runtime services relates to the persistent configuration.
> STARTING == out of sync due to still getting in sync during start
> RUNNING == in sync
> RELOAD_REQUIRED = out of sync, needs a reload to get in sync
> RESTART_REQUIRED = out of sync, needs a full process restart to get in sync
> There are two problems though with the existing attribute that exposes this:
> 1) It's named "server-state" on a server and "host-state" on a Host 
> Controller. Really crappy name; way too broad.
> That's fixable by creating a new attribute and making the old one an 
> alias for compatibility purposes.
> 2) The RUNNING state is really poorly named.
> The could perhaps be fixed by coming up with a new name and translating 
> it back to "RUNNING" in the handlers for the legacy "server-state" and 
> "host-state" attributes."



--
This message was sent by Atlassian JIRA
(v6.4.11#64026)