[jboss-jira] [JBoss JIRA] (WFCORE-273) ServerInventory#reconnectServer should take auto-start into account

[Ken Wills (JIRA)]

    [ https://issues.jboss.org/browse/WFCORE-273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13182674#comment-13182674 ] 

Ken Wills edited comment on WFCORE-273 at 3/28/16 6:25 PM:
-----------------------------------------------------------

Here are the oucomes with --restart-servers

||   || auto-start || reload --restart-servers= || Current Status || Outcome || Existing Config / add with CLI || Comments ||
|| 1 || default (true)|| not specified || running || stopped & started || (existing config) ||
|| 2 || default (true)|| not specified || not running || started || (existing config) ||
|| 3 || default (true)|| false || not running || started || (existing config) || Should this be started with --restart-servers=false? ||
|| 4 || default (true)|| true || running || stopped & started || (existing config) ||
|| 5 || false || not specified || running || stopped & not started || (existing config) ||
|| 6 || false || true || running || stopped & not started ||  (existing config) ||
|| 7 || false || false || running || not stopped & still running ||  (existing config) ||
|| 8 || true || false || not running || started || (added new server) || Should this be started with --restart-servers=false? (same as 3) ||
|| 9 || false || false || not running || not started || (added new server) ||
|| 10 || false || false || running || running || (added new server & started manually) ||
|| 11 || false || true || running || stopped & not started || (added new server & started manually) ||

So I think we'd want to think about 3 and 11

(3) If an auto-start server has been stopped, and restart-servers=false, should it restart the stopped server? (I think no.)
(11) for a new auto-start=false server, restart-servers=true doesn't start the server if it is currently running (it is stopped though). This might be ok though, as it was explicitly added with auto-start = false. (Edit, never mind 11, this behavior makes sense.)


was (Author: luck3y):
Here are the oucomes with --restart-servers

||   || auto-start || reload --restart-servers= || Current Status || Outcome || Existing Config / add with CLI || Comments ||
|| 1 || default (true)|| not specified || running || stopped & started || (existing config) ||
|| 2 || default (true)|| not specified || not running || started || (existing config) ||
|| 3 || default (true)|| false || not running || started || (existing config) || Should this be started with --restart-servers=false? ||
|| 4 || default (true)|| true || running || stopped & started || (existing config) ||
|| 5 || false || not specified || running || stopped & not started || (existing config) ||
|| 6 || false || true || running || stopped & not started ||  (existing config) ||
|| 7 || false || false || running || not stopped & still running ||  (existing config) ||
|| 8 || true || false || not running || started || (added new server) || Should this be started with --restart-servers=false? (same as 3) ||
|| 9 || false || false || not running || not started || (added new server) ||
|| 10 || false || false || running || running || (added new server & started manually) ||
|| 11 || false || true || running || stopped & not started || (added new server & started manually) ||

So I think we'd want to think about 3 and 11

(3) If an auto-start server has been stopped, and restart-servers=false, should it restart the stopped server? (I think no.)
(11) for a new auto-start=true server, restart-servers=true doesn't start the server. This might be ok though, as it was explicitly added with auto-start = false. (Edit, never mind 11, this behaviour makes sense.)

> ServerInventory#reconnectServer should take auto-start into account
> -------------------------------------------------------------------
>
>                 Key: WFCORE-273
>                 URL: https://issues.jboss.org/browse/WFCORE-273
>             Project: WildFly Core
>          Issue Type: Task
>          Components: Domain Management
>            Reporter: Emanuel Muckenhuber
>            Assignee: Ken Wills
>             Fix For: 3.0.0.Alpha1
>
>
> When reconnecting to stopped (but not removed) servers, the ServerInventory should take the auto-start property into account. Otherwise the process will just get removed, however started with the next :reload of the HC.



--
This message was sent by Atlassian JIRA
(v6.4.11#64026)