[jboss-jira] [JBoss JIRA] (WFCORE-1451) Unify/add unwrap methods to most of AttributeDefinition classes

[Brian Stansberry (JIRA)]

    [ https://issues.jboss.org/browse/WFCORE-1451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13183428#comment-13183428 ] 

Brian Stansberry commented on WFCORE-1451:
------------------------------------------

This JIRA was partly sparked by a comment I made on https://github.com/wildfly/wildfly-core/pull/1470, where a newly introduced unwrap method didn't return null.

Tomaz replied mentioning that we already have some unwrap methods that don't return null, and the he'd filed this JIRA.

I think the goals of this JIRA are fine; i.e. that having unwrap functionality in other places sounds good, and that supporting null vs empty lists is good too.

I'm fine though with having existing methods retaining their current behavior (i.e. not returning null.) Really, changing that behavior should only be done with great care, as it's very likely an API break. Probably an overloaded or differently named method for the null/empty list/normal list 3 way behavior is better.

> Unify/add unwrap methods to most of AttributeDefinition classes
> ---------------------------------------------------------------
>
>                 Key: WFCORE-1451
>                 URL: https://issues.jboss.org/browse/WFCORE-1451
>             Project: WildFly Core
>          Issue Type: Feature Request
>            Reporter: Tomaz Cerar
>            Assignee: Tomaz Cerar
>
> we now have unwrap method only on StringListAD and PropertiesAD. but there are handful of others that should have it to if possible.
> Thing to keep in mind is to make sure collection attributes can also return null as introduced in WFCORE-1448



--
This message was sent by Atlassian JIRA
(v6.4.11#64026)