[jboss-jira] [JBoss JIRA] (WFCORE-1481) list-add operation doesn't work on login-modules attribute

[Tomas Hofman (JIRA)]

    [ https://issues.jboss.org/browse/WFCORE-1481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13205325#comment-13205325 ] 

Tomas Hofman commented on WFCORE-1481:
--------------------------------------

I tried Brian's suggestion, and it's working, except that CollectionOperationsTestCase#test[Map/List]OperationsInComposite fails (https://github.com/wildfly/wildfly-core/blob/master/controller/src/test/java/org/jboss/as/controller/operation/global/CollectionOperationsTestCase.java#L400).

However, I think the test case doesn't represent real use cases.

Reason why it's failing is that:
* the tested attribute has Read Operation Step Handler defined, which simulates reading data from runtime,
* the tested attribute also has WriteOSH defined, which updates the resource model, and adds another step to update runtime, but this step is added to RUNTIME stage,
* so the list-add ops in the composite doesn't see results of previous list-add ops, because runtime is updated at the end of the composite op, not its' individual steps.

This problem doesn't happen when:
* ReadOSH is not set, because then the value is read from resource's model, which is up to date,
* or WriteOSH is doing everything in DOMAIN stage.

So I tried to look for actually existing read-write list attributes in Wildfly. The only ones I found either doesn't have ReadOSH, or are using LegacyModulesAttributeReader/Writer. LegacyModulesAttributeWriter is not using RUNTIME stage, so is not affected by this problem.

So I think this behaviour is OK..?

> list-add operation doesn't work on login-modules attribute
> ----------------------------------------------------------
>
>                 Key: WFCORE-1481
>                 URL: https://issues.jboss.org/browse/WFCORE-1481
>             Project: WildFly Core
>          Issue Type: Bug
>          Components: Domain Management
>    Affects Versions: 2.1.0.Final
>            Reporter: Bartosz Spyrko-Śmietanko
>            Assignee: Tomas Hofman
>
> Executing list-add operation on login-modules results in the modules being replaced instead of appending new module.



--
This message was sent by Atlassian JIRA
(v6.4.11#64026)