[jboss-jira] [JBoss JIRA] (JGRP-2062) TYPE_STRING does not handle unicode

[Bela Ban (JIRA)]

    [ https://issues.jboss.org/browse/JGRP-2062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13239071#comment-13239071 ] 

Bela Ban commented on JGRP-2062:
--------------------------------

I'd rather leave TYPE_STRING and _add_ another TYPE_UTF which uses UTF encoding.
Good idea about the deprecation; I might even remove that constructor in 4.0 (and deprecate it in 3.x).
Thanks for the kudos!

> TYPE_STRING does not handle unicode
> -----------------------------------
>
>                 Key: JGRP-2062
>                 URL: https://issues.jboss.org/browse/JGRP-2062
>             Project: JGroups
>          Issue Type: Bug
>            Reporter: Cody Ebberson
>            Assignee: Bela Ban
>            Priority: Minor
>             Fix For: 4.0
>
>
> In several places throughout the org.jgroups.util.Util class, it is assumed that Strings are one byte per character.
> For example, see objectToByteBuffer lines 561-567:
> https://github.com/belaban/JGroups/blob/master/src/org/jgroups/util/Util.java#L561-L567
> {{case TYPE_STRING:
>     String str=(String)obj;
>     int len=str.length();
>     ByteBuffer retval=ByteBuffer.allocate(Global.BYTE_SIZE + len).put(TYPE_STRING);
>     for(int i=0; i < len; i++)
>         retval.put((byte)str.charAt(i));
>     return retval.array();}}
> This code will incorrectly encode any String with non ASCII encoding.
> There are several options to fix.  You could use str.getBytes(StandardCharsets.UTF_8) to get a proper byte encoding, or you could use the existing TYPE_SERIALIZABLE code path.



--
This message was sent by Atlassian JIRA
(v6.4.11#64026)