[jboss-jira] [JBoss JIRA] (WFCORE-1677) Make AbstractSubsystemBaseTest#testSchemaOfSubsystemTemplates cope with substitutions properly

[Brian Stansberry (JIRA)]

    [ https://issues.jboss.org/browse/WFCORE-1677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13316353#comment-13316353 ] 

Brian Stansberry commented on WFCORE-1677:
------------------------------------------

We should look into reworking them so "opt in" means explicitly adding the test, as opposed to having them on by default but effectively @Ignored unless the user implements a method. Because of the replacement issue it's likely that a large number of subsystems will never enable these, and that's leading to a high count of "Ignored" tests on our CI runs. Which leads to occasional questions about why our test suite is ignoring so many problems and whether we need an initiative to correct that.

> Make AbstractSubsystemBaseTest#testSchemaOfSubsystemTemplates cope with substitutions properly
> ----------------------------------------------------------------------------------------------
>
>                 Key: WFCORE-1677
>                 URL: https://issues.jboss.org/browse/WFCORE-1677
>             Project: WildFly Core
>          Issue Type: Feature Request
>          Components: Test Suite
>    Affects Versions: 2.2.0.CR8
>            Reporter: Radoslav Husar
>            Assignee: Kabir Khan
>            Priority: Minor
>
> It sounds to me that the test should really be validating the generated XML files, rather than the templates.
> {noformat}
> testSchemaOfSubsystemTemplates[8](org.jboss.as.clustering.infinispan.subsystem.SubsystemParsingTestCase)  Time elapsed: 0.052 sec  <<< FAILURE!
> java.lang.AssertionError: error: cvc-complex-type.2.4.b: The content of element 'subsystem' is not complete. One of '{"urn:jboss:domain:infinispan:4.0":cache-container}' is expected.
> 	at org.junit.Assert.fail(Assert.java:88)
> 	at org.jboss.as.subsystem.test.SchemaValidator$1.error(SchemaValidator.java:73)
> 	at org.apache.xerces.util.ErrorHandlerWrapper.error(ErrorHandlerWrapper.java:135)
> 	at org.apache.xerces.impl.XMLErrorReporter.reportError(XMLErrorReporter.java:394)
> 	at org.apache.xerces.impl.XMLErrorReporter.reportError(XMLErrorReporter.java:325)
> 	at org.apache.xerces.impl.XMLErrorReporter.reportError(XMLErrorReporter.java:282)
> 	at org.apache.xerces.impl.xs.XMLSchemaValidator$XSIErrorReporter.reportError(XMLSchemaValidator.java:481)
> 	at org.apache.xerces.impl.xs.XMLSchemaValidator.reportSchemaError(XMLSchemaValidator.java:3571)
> 	at org.apache.xerces.impl.xs.XMLSchemaValidator.elementLocallyValidComplexType(XMLSchemaValidator.java:3508)
> 	at org.apache.xerces.impl.xs.XMLSchemaValidator.elementLocallyValidType(XMLSchemaValidator.java:3434)
> 	at org.apache.xerces.impl.xs.XMLSchemaValidator.processElementContent(XMLSchemaValidator.java:3336)
> 	at org.apache.xerces.impl.xs.XMLSchemaValidator.handleEndElement(XMLSchemaValidator.java:2383)
> 	at org.apache.xerces.impl.xs.XMLSchemaValidator.endElement(XMLSchemaValidator.java:894)
> 	at org.apache.xerces.impl.XMLNSDocumentScannerImpl.scanEndElement(XMLNSDocumentScannerImpl.java:673)
> 	at org.apache.xerces.impl.XMLDocumentFragmentScannerImpl$FragmentContentDispatcher.dispatch(XMLDocumentFragmentScannerImpl.java:1645)
> 	at org.apache.xerces.impl.XMLDocumentFragmentScannerImpl.scanDocument(XMLDocumentFragmentScannerImpl.java:324)
> 	at org.apache.xerces.parsers.XML11Configuration.parse(XML11Configuration.java:875)
> 	at org.apache.xerces.parsers.XML11Configuration.parse(XML11Configuration.java:798)
> 	at org.apache.xerces.jaxp.validation.StreamValidatorHelper.validate(StreamValidatorHelper.java:186)
> 	at org.apache.xerces.jaxp.validation.ValidatorImpl.validate(ValidatorImpl.java:129)
> 	at javax.xml.validation.Validator.validate(Validator.java:124)
> 	at org.jboss.as.subsystem.test.SchemaValidator.validateXML(SchemaValidator.java:123)
> 	at org.jboss.as.subsystem.test.SchemaValidator.validateXML(SchemaValidator.java:101)
> 	at org.jboss.as.subsystem.test.AbstractSubsystemBaseTest.testSchemaOfSubsystemTemplates(AbstractSubsystemBaseTest.java:144)
> 	at org.jboss.as.clustering.infinispan.subsystem.SubsystemParsingTestCase.testSchemaOfSubsystemTemplates(SubsystemParsingTestCase.java:130)
> Results :
> Failed tests:
>   SubsystemParsingTestCase.testSchemaOfSubsystemTemplates:130->AbstractSubsystemBaseTest.testSchemaOfSubsystemTemplates:144 error: cvc-complex-type.2.4.b: The content of element 'subsystem' is not complete. One of '{"urn:jboss:domain:infinispan:4.0":cache-container}' is expected.
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.2.3#72005)