[jboss-jira] [JBoss JIRA] (WFCORE-1918) re-enable quote parsing

Jean-Francois Denise (JIRA) issues at jboss.org
Fri Nov 4 08:47:00 EDT 2016


    [ https://issues.jboss.org/browse/WFCORE-1918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13317464#comment-13317464 ] 

Jean-Francois Denise commented on WFCORE-1918:
----------------------------------------------

Perhaps that the fix for WFCORE-1804 should be done for comment only.

We should not parse " when in comments ==> 6.4 behaviour.
We should parse them if not in comments ==> 7.0 behaviour.

[~mkopecky], seems that would fix JBEAP-6037

> re-enable quote parsing
> -----------------------
>
>                 Key: WFCORE-1918
>                 URL: https://issues.jboss.org/browse/WFCORE-1918
>             Project: WildFly Core
>          Issue Type: Bug
>          Components: CLI
>    Affects Versions: 3.0.0.Alpha11
>            Reporter: Hisanobu Okuda
>            Assignee: Jean-Francois Denise
>
> The fix for WFCORE-1804 was committed [here|https://github.com/wildfly/wildfly-core/commit/027bfe959988b25e45771491e494ca61c19a986b#diff-c929deeb25b1e0886f6c256907ea7c44].
> It has a side-effect that it disables quote parsing. Now the [another fix|https://github.com/aeshell/aesh/commit/0e8aa5cf514d5af81b16f7741c92a6547f4be0a1] which does not have the side-effect was committed in [aesh|https://github.com/aeshell/aesh]. The following line in the [previous fix|ttps://github.com/wildfly/wildfly-core/commit/027bfe959988b25e45771491e494ca61c19a986b#diff-c929deeb25b1e0886f6c256907ea7c44] should be removed, when the new aesh version is released (0.66.11 or 12?).
> ??cli/src/main/java/org/jboss/as/cli/impl/CommandContextImpl.java:495??
> {code}
>         settings.parsingQuotes(false);
> {code}



--
This message was sent by Atlassian JIRA
(v7.2.3#72005)


More information about the jboss-jira mailing list