[jboss-jira] [JBoss JIRA] (WFLY-7219) Wrong description of missing target-name in simple-permission-mapper

[Ilia Vassilev (JIRA)]

    [ https://issues.jboss.org/browse/WFLY-7219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13317643#comment-13317643 ] 

Ilia Vassilev commented on WFLY-7219:
-------------------------------------

[~honza889] One way of knowing if "target-name" or/and "action" are required in the subsystem is to get the number of arguments from the permission class by implementing similar logic like PermissionUtil.createPermission or expose this functionality from Elytron. When we catch the exception in Elytron Subsystem we can throw a specific message if:
1. twoArg: "target-name" and "action" are both required
2. oneArg: "target-name" is required, "action" can be null.
3. noArgs: "target-name" and "action" are optional and can be null

We already check if class-name is null.

> Wrong description of missing target-name in simple-permission-mapper
> --------------------------------------------------------------------
>
>                 Key: WFLY-7219
>                 URL: https://issues.jboss.org/browse/WFLY-7219
>             Project: WildFly
>          Issue Type: Bug
>          Components: Security
>            Reporter: Ondrej Lukas
>            Assignee: Jan Kalina
>              Labels: user_experience
>             Fix For: 11.0.0.Alpha1
>
>
> In case when simple-permission-mapper cannot be added through CLI command due to missing target-name attribute, then IllegalArgumentException with wrong description is thrown. It says: "Parameter '*name*' may not be null". It should be "Parameter '*target-name*' may not be null".



--
This message was sent by Atlassian JIRA
(v7.2.3#72005)