[jboss-jira] [JBoss JIRA] (WFLY-7146) Elytron, regex-name-validating-rewriter - 'match' attribute required and unclear description

[Ilia Vassilev (JIRA)]

    [ https://issues.jboss.org/browse/WFLY-7146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13319614#comment-13319614 ] 

Ilia Vassilev commented on WFLY-7146:
-------------------------------------

Submitted new PR [1] for the requested changes from JBEAP-5986.

[1] https://github.com/wildfly-security/elytron-subsystem/pull/291

> Elytron, regex-name-validating-rewriter - 'match' attribute required and unclear description
> --------------------------------------------------------------------------------------------
>
>                 Key: WFLY-7146
>                 URL: https://issues.jboss.org/browse/WFLY-7146
>             Project: WildFly
>          Issue Type: Bug
>          Components: Security
>            Reporter: Jan Kalina
>            Assignee: Ilia Vassilev
>            Priority: Minor
>             Fix For: 11.0.0.Alpha1
>
>
> Attribute 'match' is required when adding 'regex-name-validating-rewriter' although when reading the resource description via CLI, I can see that it has defined default value (true) and in [XSD file|https://github.com/wildfly-security/elytron-subsystem/blob/1.0.0.Alpha9/src/main/resources/schema/wildfly-elytron_1_0.xsd] it is not stated as a 'required'. Try:
> {code}
> /subsystem=elytron/regex-name-validating-rewriter=nameRewriter:add(pattern=".*")
> {
>     "outcome" => "failed",
>     "failure-description" => "WFLYCTL0172: match is required",
>     "rolled-back" => true
> }
> {code}
> When you try to add also with 'match' attribute then rewriter is added successfully.
> Also - the 'match' attribute description in CLI is not quite clear:
> {code}
> /subsystem=elytron/regex-name-validating-rewriter=nameRewriter:read-resource-description
> ...
>             "match" => {
>                 "type" => BOOLEAN,
>                 "description" => "Should names that match the pattern be rejected or names that don't",
>                 "expressions-allowed" => true,
>                 "nillable" => false,
>                 "default" => true,
>                 "access-type" => "read-write",
>                 "storage" => "configuration",
>                 "restart-required" => "resource-services"
>             },
> ...
> {code}
> After reading the description I still don't know what happens when pattern matches the name and value of 'match' attribute is set to 'true' - will it be rejected or not?
> Expected behaviour:
> # 'match' attribute to be arbitrary (or change XSD so it is in sync with model)
> # more clear description of 'match' attribute



--
This message was sent by Atlassian JIRA
(v7.2.3#72005)