[jboss-jira] [JBoss JIRA] (ELY-751) Coverity static analysis: Explicit null dereferenced in LdapKeyStore (Elytron)

[Josef Cacek (JIRA)]

Josef Cacek created ELY-751:
-------------------------------

             Summary: Coverity static analysis: Explicit null dereferenced in LdapKeyStore (Elytron)
                 Key: ELY-751
                 URL: https://issues.jboss.org/browse/ELY-751
             Project: WildFly Elytron
          Issue Type: Bug
            Reporter: Josef Cacek
            Assignee: Darran Lofthouse
            Priority: Critical


Coverity static-analysis scan found possible use of null object in  {{LdapKeyStore}} constructor.

https://scan7.coverity.com/reports.htm#v16159/p11778/fileInstanceId=5760194&defectInstanceId=1541374&mergedDefectId=1369294
The {{LdapKeyStore.Builder.build()}} method constructs the {{LdapKeyStore}} instance this way:
{code}
  return new LdapKeyStore(spi, null, null);
{code}
and the constructor just calls parent ctor:
{code}
    protected LdapKeyStore(KeyStoreSpi keyStoreSpi, Provider provider, String type) {
        super(keyStoreSpi, provider, type);
    }
{code}

And it fails with NPE if debug for {{KeyStore}} is enabled as the constructor contains:
{code}
        if (!skipDebug && pdebug != null) {
            pdebug.println("KeyStore." + type.toUpperCase() + " type from: " +
                this.provider.getName());
        }
{code}





--
This message was sent by Atlassian JIRA
(v7.2.3#72005)