[jboss-jira] [JBoss JIRA] (ELY-770) Review SASL mechanism handling of isComplete()

[Darran Lofthouse (JIRA)]

Darran Lofthouse created ELY-770:
------------------------------------

             Summary: Review SASL mechanism handling of isComplete()
                 Key: ELY-770
                 URL: https://issues.jboss.org/browse/ELY-770
             Project: WildFly Elytron
          Issue Type: Task
          Components: SASL
            Reporter: Darran Lofthouse
            Priority: Critical
             Fix For: 1.1.0.Beta15


The javadoc of the isComplete() method states: -

_Determines whether the authentication exchange has completed. This method is typically called after each invocation of evaluateResponse() to determine whether the authentication has completed successfully or should be continued._

Also getAuthorizationID() states: -

_Reports the authorization ID in effect for the client of this session. This method can only be called if isComplete() returns true.
_

Although the former is very vague there just seem to be a suggestion that complete means successfully complete, our mechs are setting complete very early and other wrappers such as AuthenticationCompleteCallbackSaslServerFactory are using complete as a flag to report failures.




--
This message was sent by Atlassian JIRA
(v7.2.3#72005)