[jboss-jira] [JBoss JIRA] (ELY-653) KeystorePasswordStore contains inconsistency about MODIFIABLE configuration attribute

[Hynek Švábek (JIRA)]

     [ https://issues.jboss.org/browse/ELY-653?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Hynek Švábek updated ELY-653:
-----------------------------
    Description: 
KeystorePasswordStore contains inconsistency about MODIFIABLE configuration attribute.

Here it is used MODIFIABLE attribute:
https://github.com/wildfly-security/wildfly-elytron/blob/1.1.0.Beta10/src/main/java/org/wildfly/security/credential/store/impl/KeystorePasswordStore.java#L275

But it is missing between supported configuration attributes:
https://github.com/wildfly-security/wildfly-elytron/blob/1.1.0.Beta10/src/main/java/org/wildfly/security/credential/store/impl/KeystorePasswordStore.java#L222

I cannot see any condition with isModifiable() in *store()* or *remove()* method:
https://github.com/wildfly-security/wildfly-elytron/blob/1.1.0.Beta10/src/main/java/org/wildfly/security/credential/store/impl/KeystorePasswordStore.java#L317

In my opinion MODIFIABLE attribute should be supported otherwise please remove code about MODIFIABLE from *initialize()* method.

  was:
KeystorePasswordStore contains inconsistency about MODIFIABLE configuration attribute.

Here it is used MODIFIABLE attribute:
https://github.com/wildfly-security/wildfly-elytron/blob/1.1.0.Beta10/src/main/java/org/wildfly/security/credential/store/impl/KeystorePasswordStore.java#L275

But it is missing between supported configuration attributes:
https://github.com/wildfly-security/wildfly-elytron/blob/1.1.0.Beta10/src/main/java/org/wildfly/security/credential/store/impl/KeystorePasswordStore.java#L222

I cannot see any condition with isModifiable() in *store()* method:
https://github.com/wildfly-security/wildfly-elytron/blob/1.1.0.Beta10/src/main/java/org/wildfly/security/credential/store/impl/KeystorePasswordStore.java#L317

In my opinion MODIFIABLE attribute should be supported otherwise please remove code about MODIFIABLE from *initialize()* method.



> KeystorePasswordStore contains inconsistency about MODIFIABLE configuration attribute
> -------------------------------------------------------------------------------------
>
>                 Key: ELY-653
>                 URL: https://issues.jboss.org/browse/ELY-653
>             Project: WildFly Elytron
>          Issue Type: Bug
>            Reporter: Hynek Švábek
>            Assignee: Peter Skopek
>
> KeystorePasswordStore contains inconsistency about MODIFIABLE configuration attribute.
> Here it is used MODIFIABLE attribute:
> https://github.com/wildfly-security/wildfly-elytron/blob/1.1.0.Beta10/src/main/java/org/wildfly/security/credential/store/impl/KeystorePasswordStore.java#L275
> But it is missing between supported configuration attributes:
> https://github.com/wildfly-security/wildfly-elytron/blob/1.1.0.Beta10/src/main/java/org/wildfly/security/credential/store/impl/KeystorePasswordStore.java#L222
> I cannot see any condition with isModifiable() in *store()* or *remove()* method:
> https://github.com/wildfly-security/wildfly-elytron/blob/1.1.0.Beta10/src/main/java/org/wildfly/security/credential/store/impl/KeystorePasswordStore.java#L317
> In my opinion MODIFIABLE attribute should be supported otherwise please remove code about MODIFIABLE from *initialize()* method.



--
This message was sent by Atlassian JIRA
(v6.4.11#64026)