[jboss-jira] [JBoss JIRA] (DROOLS-1334) Kie service client should not allow null parameters

[Slavomir Krupa (JIRA)]

Slavomir Krupa created DROOLS-1334:
--------------------------------------

             Summary: Kie service client should not allow null parameters
                 Key: DROOLS-1334
                 URL: https://issues.jboss.org/browse/DROOLS-1334
             Project: Drools
          Issue Type: Bug
          Components: kie server
    Affects Versions: 6.4.0.Final
            Reporter: Slavomir Krupa
            Assignee: Edson Tirelli


This issue occurs when you are using a kie-server-client and want to query i.e. 
{code:java}
List<TaskSummary> findTasksByStatusByProcessInstanceId(Long processInstanceId, List<String> status, Integer page, Integer pageSize);
{code}
If you don't provide a processInstanceId it creates this URL:
{noformat}
http://localhost:8080/kie-server/services/rest/server/queries/tasks/instances/process/%7BpInstanceId%7D?status=Ready&page=0&pageSize=50
{noformat}
Result is a exception on the server, but I think it should be validated in a client and should not even query the server:

{noformat}
ERROR [org.jboss.resteasy.resteasy_jaxrs.i18n] (http-127.0.0.1:8080-6) RESTEASY000100: Failed executing GET server/queries/tasks/instances/process/{pInstanceId}: org.jboss.resteasy.spi.BadRequestException: RESTEASY001720: Unable to extract parameter from http request: javax.ws.rs.PathParam("pInstanceId") value is {1} for public javax.ws.rs.core.Response org.kie.server.remote.rest.jbpm.RuntimeDataResource.getTasksByStatusByProcessInstanceId(javax.ws.rs.core.HttpHeaders,java.lang.Long,java.util.List,java.lang.Integer,java.lang.Integer,java.lang.String,boolean)
	at org.jboss.resteasy.core.StringParameterInjector.extractValue(StringParameterInjector.java:310) [resteasy-jaxrs-2.3.15.Final-redhat-1.jar:]
	at org.jboss.resteasy.core.PathParamInjector.inject(PathParamInjector.java:117) [resteasy-jaxrs-2.3.15.Final-redhat-1.jar:]
	at org.jboss.resteasy.core.MethodInjectorImpl.injectArguments(MethodInjectorImpl.java:137) [resteasy-jaxrs-2.3.15.Final-redhat-1.jar:]
	at org.jboss.resteasy.core.MethodInjectorImpl.invoke(MethodInjectorImpl.java:160) [resteasy-jaxrs-2.3.15.Final-redhat-1.jar:]
	at org.jboss.resteasy.core.ResourceMethod.invokeOnTarget(ResourceMethod.java:269) [resteasy-jaxrs-2.3.15.Final-redhat-1.jar:]
	at org.jboss.resteasy.core.ResourceMethod.invoke(ResourceMethod.java:227) [resteasy-jaxrs-2.3.15.Final-redhat-1.jar:]
	at org.jboss.resteasy.core.ResourceMethod.invoke(ResourceMethod.java:216) [resteasy-jaxrs-2.3.15.Final-redhat-1.jar:]
	at org.jboss.resteasy.core.SynchronousDispatcher.getResponse(SynchronousDispatcher.java:560) [resteasy-jaxrs-2.3.15.Final-redhat-1.jar:]
	at org.jboss.resteasy.core.SynchronousDispatcher.invoke(SynchronousDispatcher.java:542) [resteasy-jaxrs-2.3.15.Final-redhat-1.jar:]
	at org.jboss.resteasy.core.SynchronousDispatcher.invoke(SynchronousDispatcher.java:130) [resteasy-jaxrs-2.3.15.Final-redhat-1.jar:]
	at org.jboss.resteasy.plugins.server.servlet.ServletContainerDispatcher.service(ServletContainerDispatcher.java:208) [resteasy-jaxrs-2.3.15.Final-redhat-1.jar:]
	at org.jboss.resteasy.plugins.server.servlet.HttpServletDispatcher.service(HttpServletDispatcher.java:55) [resteasy-jaxrs-2.3.15.Final-redhat-1.jar:]
	at org.jboss.resteasy.plugins.server.servlet.HttpServletDispatcher.service(HttpServletDispatcher.java:50) [resteasy-jaxrs-2.3.15.Final-redhat-1.jar:]
	at javax.servlet.http.HttpServlet.service(HttpServlet.java:847) [jboss-servlet-api_3.0_spec-1.0.2.Final-redhat-2.jar:1.0.2.Final-redhat-2]
	at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:295) [jbossweb-7.5.17.Final-redhat-1.jar:7.5.17.Final-redhat-1]
	at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:214) [jbossweb-7.5.17.Final-redhat-1.jar:7.5.17.Final-redhat-1]
	at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:231) [jbossweb-7.5.17.Final-redhat-1.jar:7.5.17.Final-redhat-1]
	at org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:149) [jbossweb-7.5.17.Final-redhat-1.jar:7.5.17.Final-redhat-1]
	at org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:512) [jbossweb-7.5.17.Final-redhat-1.jar:7.5.17.Final-redhat-1]
	at org.jboss.as.web.security.SecurityContextAssociationValve.invoke(SecurityContextAssociationValve.java:169) [jboss-as-web-7.5.10.Final-redhat-2.jar:7.5.10.Final-redhat-2]
	at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:150) [jbossweb-7.5.17.Final-redhat-1.jar:7.5.17.Final-redhat-1]
	at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:97) [jbossweb-7.5.17.Final-redhat-1.jar:7.5.17.Final-redhat-1]
	at org.apache.catalina.authenticator.SingleSignOn.invoke(SingleSignOn.java:400) [jbossweb-7.5.17.Final-redhat-1.jar:7.5.17.Final-redhat-1]
	at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:102) [jbossweb-7.5.17.Final-redhat-1.jar:7.5.17.Final-redhat-1]
	at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:344) [jbossweb-7.5.17.Final-redhat-1.jar:7.5.17.Final-redhat-1]
	at org.apache.coyote.http11.Http11Processor.process(Http11Processor.java:854) [jbossweb-7.5.17.Final-redhat-1.jar:7.5.17.Final-redhat-1]
	at org.apache.coyote.http11.Http11Protocol$Http11ConnectionHandler.process(Http11Protocol.java:654) [jbossweb-7.5.17.Final-redhat-1.jar:7.5.17.Final-redhat-1]
	at org.apache.tomcat.util.net.JIoEndpoint$Worker.run(JIoEndpoint.java:926) [jbossweb-7.5.17.Final-redhat-1.jar:7.5.17.Final-redhat-1]
	at java.lang.Thread.run(Thread.java:745) [rt.jar:1.8.0_65]
Caused by: java.lang.reflect.InvocationTargetException
	at sun.reflect.GeneratedConstructorAccessor154.newInstance(Unknown Source) [:1.8.0_65]
	at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45) [rt.jar:1.8.0_65]
	at java.lang.reflect.Constructor.newInstance(Constructor.java:422) [rt.jar:1.8.0_65]
	at org.jboss.resteasy.core.StringParameterInjector.extractValue(StringParameterInjector.java:298) [resteasy-jaxrs-2.3.15.Final-redhat-1.jar:]
	... 28 more
Caused by: java.lang.NumberFormatException: For input string: "{pInstanceId}"
	at java.lang.NumberFormatException.forInputString(NumberFormatException.java:65) [rt.jar:1.8.0_65]
	at java.lang.Long.parseLong(Long.java:589) [rt.jar:1.8.0_65]
	at java.lang.Long.<init>(Long.java:965) [rt.jar:1.8.0_65]
	... 32 more
{noformat}






--
This message was sent by Atlassian JIRA
(v6.4.11#64026)