[jboss-jira] [JBoss JIRA] (WFCORE-1769) DomainRootDefinition.RolloutPlanValidator is throwing OFE when it should just be an assert

[Brian Stansberry (JIRA)]

Brian Stansberry created WFCORE-1769:
----------------------------------------

             Summary: DomainRootDefinition.RolloutPlanValidator is throwing OFE when it should just be an assert
                 Key: WFCORE-1769
                 URL: https://issues.jboss.org/browse/WFCORE-1769
             Project: WildFly Core
          Issue Type: Bug
          Components: Domain Management
            Reporter: Brian Stansberry
            Assignee: Brian Stansberry
            Priority: Minor
             Fix For: 3.0.0.Alpha8


The ParameterValidator javadoc declares the 'value' parameter cannot be null, so a null param value should result in an AssertionError or an IAE. But RolloutPlanValidator is throwing an OFE. OFE should be used for user errors (i.e. invalid requests), not coding mistakes. The data passed to a validator is not under the control of the user; passing a null means a coding mistake.

The caller of a ParameterValidator is the kernel, not outside code, so we are not validating unknown inputs. So an assert is fine; no need for an IAE.



--
This message was sent by Atlassian JIRA
(v6.4.11#64026)