[jboss-jira] [JBoss JIRA] (WFCORE-1127) SocketBindingManagerImpl$UnnamedRegistryImpl is overly picky about unbound sockets

[Paul Ferraro (JIRA)]

    [ https://issues.jboss.org/browse/WFCORE-1127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13291169#comment-13291169 ] 

Paul Ferraro commented on WFCORE-1127:
--------------------------------------

[~dan.berindei]
"JGroups prior to version 4.0 "fixes" this by always replacing the ManagedSocketFactory set by JChannelFactory.init() with its own DefaultSocketFactory in JChannel.startStack()."

That not the case in WF 10.  This was corrected almost a year ago:
https://github.com/wildfly/wildfly/commit/ab5b4358aef108dfa8296b1f5df7888d90425031

This exposed a number of issues with unbound sockets and the SocketBindingManager - all of which were fixed, such that WildFly 10.x uses the the provided ManagedSocketFactory w/JGroups 3.6.x without issue.  Granted, I haven't tried this with JGroups 4 yet, but it seems to me that the infinispan-server fork of WildFly's jgroups subsystem is quite out of date.

> SocketBindingManagerImpl$UnnamedRegistryImpl is overly picky about unbound sockets
> ----------------------------------------------------------------------------------
>
>                 Key: WFCORE-1127
>                 URL: https://issues.jboss.org/browse/WFCORE-1127
>             Project: WildFly Core
>          Issue Type: Bug
>          Components: Domain Management
>    Affects Versions: 2.0.1.Final
>            Reporter: Brian Stansberry
>            Assignee: Brian Stansberry
>             Fix For: 2.0.2.Final
>
>
> A failure like this isn't necessary:
> {code}
> 08:02:23,475 ERROR [org.jboss.msc.service.fail] (MSC service thread 1-2) MSC000001: Failed to start service jboss.jgroups.channel.ee.connector: org.jboss.msc.service.StartException in service jboss.jgroups.channel.ee.connector: java.lang.IllegalStateException
>     at org.wildfly.clustering.jgroups.spi.service.ChannelConnectorBuilder.start(ChannelConnectorBuilder.java:96)
>     at org.jboss.msc.service.ServiceControllerImpl$StartTask.startService(ServiceControllerImpl.java:1948)
>     at org.jboss.msc.service.ServiceControllerImpl$StartTask.run(ServiceControllerImpl.java:1881)
>     at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
>     at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
>     at java.lang.Thread.run(Thread.java:745)
> Caused by: java.lang.IllegalStateException
>     at org.jboss.as.network.SocketBindingManagerImpl$UnnamedRegistryImpl.unregisterBinding(SocketBindingManagerImpl.java:501)
>     at org.jboss.as.network.ManagedDatagramSocketBinding.close(ManagedDatagramSocketBinding.java:73)
>     at org.jboss.as.clustering.jgroups.ManagedSocketFactory.close(ManagedSocketFactory.java:148)
>     at org.jgroups.protocols.UDP.closeUnicastSocket(UDP.java:577)
>     at org.jgroups.protocols.UDP.destroySockets(UDP.java:429)
>     at org.jgroups.protocols.UDP.start(UDP.java:274)
>     at org.jgroups.stack.ProtocolStack.startStack(ProtocolStack.java:965)
>     at org.jgroups.JChannel.startStack(JChannel.java:890)
>     at org.jgroups.JChannel._preConnect(JChannel.java:553)
>     at org.jgroups.JChannel.connect(JChannel.java:288)
>     at org.jgroups.JChannel.connect(JChannel.java:279)
>     at org.wildfly.clustering.jgroups.spi.service.ChannelConnectorBuilder.start(ChannelConnectorBuilder.java:94)
>     ... 5 more
> {code}
> If there's no socket address, it should just move on.



--
This message was sent by Atlassian JIRA
(v6.4.11#64026)