[jboss-jira] [JBoss JIRA] (WFCORE-1799) Property separator not appended after argument value if argument completer uses non-zero offset

[Bartosz Spyrko-Śmietanko (JIRA)]

Bartosz Spyrko-Śmietanko created WFCORE-1799:
------------------------------------------------

             Summary: Property separator not appended after argument value if argument completer uses non-zero offset
                 Key: WFCORE-1799
                 URL: https://issues.jboss.org/browse/WFCORE-1799
             Project: WildFly Core
          Issue Type: Bug
          Components: CLI
    Affects Versions: 3.0.0.Alpha7
            Reporter: Bartosz Spyrko-Śmietanko
            Assignee: Bartosz Spyrko-Śmietanko
            Priority: Minor


For example:
module add --name=foo --dependencies=sun.scripting ==> space character is added at the end.
module add --name=foo --dependencies=sun.scripting,sun.jdk ==> Nothing happens, no space character added.
deployment-overlay add --name=foo --contents=foo=/some/file<TAB> ==> Nothing happens, no space character added.

This seems to be caused by a condition in  [OperationRequestCompleter|https://github.com/wildfly/wildfly-core/blob/bc4988960e9bd245318321a06ae3d001ec661bc5/cli/src/main/java/org/jboss/as/cli/operation/OperationRequestCompleter.java#L233] - if a suggested value is the same as current user input, ORC replaces the suggestion with a separator.
This only works if the offset returned by argument completer is 0 - if the completer provides only part of the value, this condition will never be triggered.



--
This message was sent by Atlassian JIRA
(v6.4.11#64026)