[jboss-jira] [JBoss JIRA] (JBJCA-1325) Wrong condition when parsing ironjacamar.rollback_on_fatal_error property

[Martin Simka (JIRA)]

    [ https://issues.jboss.org/browse/JBJCA-1325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13296468#comment-13296468 ] 

Martin Simka commented on JBJCA-1325:
-------------------------------------

[~istudens] PR is merged, this should be resolved

> Wrong condition when parsing ironjacamar.rollback_on_fatal_error property
> -------------------------------------------------------------------------
>
>                 Key: JBJCA-1325
>                 URL: https://issues.jboss.org/browse/JBJCA-1325
>             Project: IronJacamar
>          Issue Type: Bug
>    Affects Versions: WildFly/IronJacamar 1.3.4.Final
>            Reporter: Martin Simka
>            Assignee: Ivo Studensky
>
> There is wrong condition in https://github.com/ironjacamar/ironjacamar/blob/1.3/core/src/main/java/org/jboss/jca/core/connectionmanager/listener/TxConnectionListener.java#L180
> {code:java}
>       value = SecurityActions.getSystemProperty("ironjacamar.rollback_on_fatal_error");
>       if (value != null && !value.trim().equals(""))
>       {
>          if ("true".equalsIgnoreCase(value) || "false".equalsIgnoreCase(value))
>          {
>             doSetRollbackOnly = Boolean.parseBoolean(value);
>          }
>          else
>          {
>             StringTokenizer st = new StringTokenizer(value, ",");
>             while (doDelistResource && st.hasMoreTokens()) // <-- should be while (doSetRollbackOnly ...
>             {
>                if (getPool().getName().equals(st.nextToken()))
>                   doSetRollbackOnly = false;
>             }
>          }
>       }
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.11#64026)