[jboss-jira] [JBoss JIRA] (WFLY-7203) Elytron - inconsistency between DMR and XSD representation of regex-name-validating-rewriter

[Jan Kalina (JIRA)]

    [ https://issues.jboss.org/browse/WFLY-7203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13298358#comment-13298358 ] 

Jan Kalina commented on WFLY-7203:
----------------------------------

Match should be optional - it has default value. (in both - XSD and in model)

> Elytron - inconsistency between DMR and XSD representation of regex-name-validating-rewriter
> --------------------------------------------------------------------------------------------
>
>                 Key: WFLY-7203
>                 URL: https://issues.jboss.org/browse/WFLY-7203
>             Project: WildFly
>          Issue Type: Bug
>          Components: Security
>            Reporter: Jan Tymel
>            Assignee: Darran Lofthouse
>            Priority: Optional
>
> There is an inconsistency between DMR and XSD representation of {{regex-name-validating-rewriter}}.
> According to XSD[1] is {{match}} attribute optional. On the other hand DMR[2] says that {{match}} attribute is mandatory (_"nillable" => false_).
> {{Match}} attribute is currently required if user adds a new regex-name-validating-rewriter. Is it an intentional behaviour or should {{match}} be optional (=according to XSD definition)?
> [1] https://github.com/wildfly-security/elytron-subsystem/blob/master/src/main/resources/schema/wildfly-elytron_1_0.xsd#L1321
> [2] {{/subsystem=elytron:read-resource-description(recursive=true)}}
> {code}
> "regex-name-validating-rewriter" => {
>                 "description" => "A regular expression based Name Rewriter which uses the regular expression to validate the name.",
>                 "model-description" => {"*" => {
>                     "description" => "A regular expression based Name Rewriter which uses the regular expression to validate the name.",
>                     "capabilities" => [{
>                         "name" => "org.wildfly.security.name-rewriter",
>                         "dynamic" => true
>                     }],
>                     "attributes" => {
>                         "match" => {
>                             "type" => BOOLEAN,
>                             "description" => "Should names that match the pattern be rejected or names that don't",
>                             "expressions-allowed" => true,
>                             "nillable" => false,
>                             "default" => true,
>                             "access-type" => "read-write",
>                             "storage" => "configuration",
>                             "restart-required" => "resource-services"
>                         },
>                         "pattern" => {
>                             "type" => STRING,
>                             "description" => "The regular expression to use to locate the portion of the name to be replaced.",
>                             "expressions-allowed" => true,
>                             "nillable" => false,
>                             "min-length" => 1L,
>                             "max-length" => 2147483647L,
>                             "access-type" => "read-write",
>                             "storage" => "configuration",
>                             "restart-required" => "resource-services"
>                         }
>                     },
>                     "operations" => undefined,
>                     "notifications" => undefined,
>                     "children" => {}
>                 }}
>             }
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.11#64026)