[jboss-jira] [JBoss JIRA] (JBJCA-1334) Add DataSource to ManagementRepository only after deployed successfully

[Lin Gao (JIRA)]

    [ https://issues.jboss.org/browse/JBJCA-1334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13300122#comment-13300122 ] 

Lin Gao edited comment on JBJCA-1334 at 9/29/16 4:09 AM:
---------------------------------------------------------

This Jira is created by cloning the WFLY-7214.

The reason for the problem is that {{AbstractDsDeployer}} [added the DataSource into ManagementRepository|https://github.com/ironjacamar/ironjacamar/blob/1.3/deployers/src/main/java/org/jboss/jca/deployers/common/AbstractDsDeployer.java#L631] before it knows that the DataSource deployment will succeed. Move the addition a little late will solve the problem.

{{test-connection-in-pool()}} operation in WildFly CLI tries to match the DataSource by iterating DataSouces in the ManagementRepository.

Left the failed DataSource in the ManagementRepository is an error tone, so we need to clear it in case of exceptions.


was (Author: gaol):
This Jira is created by cloning the WFLY-7214.

The reason for the problem is that {{AbstractDsDeployer}} [added the DataSource into ManagementRepository|https://github.com/ironjacamar/ironjacamar/blob/1.3/deployers/src/main/java/org/jboss/jca/deployers/common/AbstractDsDeployer.java#L631] before it knows that the DataSource deployment will succeed. Move the addition a little late will solve the problem.

> Add DataSource to ManagementRepository only after deployed successfully
> -----------------------------------------------------------------------
>
>                 Key: JBJCA-1334
>                 URL: https://issues.jboss.org/browse/JBJCA-1334
>             Project: IronJacamar
>          Issue Type: Bug
>          Components: Deployer
>            Reporter: Lin Gao
>            Assignee: Jesper Pedersen
>
> When a data-source was failed to be added either because of missing connection-properties:
> {code:}
> /subsystem=datasources/data-source=XXX:add(jndi-name=java:/XXX, datasource-class=XXX,driver-name=h2)
> {code}
> or missing of connection-url:
> {code:}
> /subsystem=datasources/data-source=XXX:add(jndi-name=java:/XXX, driver-name=h2)
> {code}
> , it can be added by correcting the information, like:
> {code:}
> [standalone at localhost:9990 /] /subsystem=datasources/data-source=XXX:add(jndi-name=java:/XXX, driver-name=h2,connection-url="jdbc:h2:test")
> {"outcome" => "success"}
> {code}
> But the {{test-connection-in-pool()}} operation failed with {{IllegalStateException}} of the new created data-source.



--
This message was sent by Atlassian JIRA
(v6.4.11#64026)