[jboss-jira] [JBoss JIRA] (WFLY-8512) Private undertow capability service values expose org.jboss.msc.service.Service methods

[Brian Stansberry (JIRA)]

    [ https://issues.jboss.org/browse/WFLY-8512?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13389477#comment-13389477 ] 

Brian Stansberry commented on WFLY-8512:
----------------------------------------

Thanks for the JIRA though; we need a tracker to clean this up and get contracts that we can make public.

The current capabilities are private but are used externally. This is no worse than what we had before where the services were used externally directly, which is why I was ok with what's been done so far.

Beyond not implementing Service, the types exposed by the capabilities need to be scrubbed of methods that are not needed externally.

> Private undertow capability service values expose org.jboss.msc.service.Service methods
> ---------------------------------------------------------------------------------------
>
>                 Key: WFLY-8512
>                 URL: https://issues.jboss.org/browse/WFLY-8512
>             Project: WildFly
>          Issue Type: Enhancement
>          Components: Web (Undertow)
>    Affects Versions: 11.0.0.Alpha1
>            Reporter: Paul Ferraro
>            Assignee: Tomaz Cerar
>            Priority: Minor
>
> Undertow new exposes UndertowService, Server, Host, etc. to other subsystems as service values of public capabilities.   However, these objects all implement Service, and thus expose start/stop methods to their dependents. This is poor encapsulation.  Ideally, we should extract interfaces from these objects such that the corresponding capabilities only expose methods in explicitly in their contract.



--
This message was sent by Atlassian JIRA
(v7.2.3#72005)