[jboss-jira] [JBoss JIRA] (JBJCA-1344) race condition between PoolFiller and CapacityFiller results in wrong pool statistics

[Brian Stansberry (JIRA)]

    [ https://issues.jboss.org/browse/JBJCA-1344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13394112#comment-13394112 ] 

Brian Stansberry commented on JBJCA-1344:
-----------------------------------------

Please do something about ResourceAdapterCapacityPoliciesTestCase which is failing very regularly now and adding a lot of noise to our CI runs.

https://ci.wildfly.org/project.html?projectId=WildFlyCore&buildTypeId=&tab=testDetails&testNameId=-7774392236755471173&order=TEST_STATUS_DESC&branch_WildFlyCore=__all_branches__&itemsCount=50

https://ci.wildfly.org/project.html?projectId=WF&buildTypeId=&tab=testDetails&testNameId=-7774392236755471173&order=TEST_STATUS_DESC&branch_WF=__all_branches__&itemsCount=50

> race condition between PoolFiller and CapacityFiller results in wrong pool statistics
> -------------------------------------------------------------------------------------
>
>                 Key: JBJCA-1344
>                 URL: https://issues.jboss.org/browse/JBJCA-1344
>             Project: IronJacamar
>          Issue Type: Bug
>    Affects Versions: 	 WildFly/IronJacamar 1.4.2.Final
>            Reporter: Martin Simka
>            Assignee: Flavia Rainone
>         Attachments: fail.log, pass.log
>
>
> There seems to be race condition between PoolFiller and CapacityFiller which results in wrong pool statistics
> I think what happens is:
>  - Both add connections to pool in different threads
>  - PoolFiller creates connection, then checks pools size and because pool has already certain size, it doesn't add connection and instead it destroys connection which increases destroyedCount
> see [SemaphoreConcurrentLinkedDequeManagedConnectionPool.java#L1163|https://github.com/ironjacamar/ironjacamar/blob/1.4/core/src/main/java/org/jboss/jca/core/connectionmanager/pool/mcp/SemaphoreConcurrentLinkedDequeManagedConnectionPool.java#L1163]



--
This message was sent by Atlassian JIRA
(v7.2.3#72005)