[jboss-jira] [JBoss JIRA] (ELY-1098) WildFly Elytron Client Configuration File created based on elytron-1_0.xsd is not valid for clients

David Lloyd (JIRA) issues at jboss.org
Tue Apr 25 10:47:00 EDT 2017


    [ https://issues.jboss.org/browse/ELY-1098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13397791#comment-13397791 ] 

David Lloyd commented on ELY-1098:
----------------------------------

bq. root element {{configuration}} is not included in elytron-1_0.xsd, it means that configuration with {{configuration}} are handled as invalid and configuration which has {{authentication-client}} as root element as valid

The root element "configuration" should be without namespace, thus it does not belong in any one XSD.  Relatedly, it may contain many nested elements, each with different namespaces, which allows all client configuration to exist in a single document (even future APIs which are not yet defined).

We could have put "configuration" into its own namespace with an XSD containing a single root element whose type is "xs:any" but that would just mean that the user would have to put in a meaningless namespace onto that root element.  We could still do that though as a possibility.  I'd want to get a few diverse opinions on that first though, particularly from the support team.

bq. XSD elytron-1_0.xsd includes some elements on the highest level of XSD, which for example means that configuration file which includes only element <set-user-name name="someUser"/> is valid according to XSD.

There's nothing we can do about this.  XML schema is very limited on structure.  We certainly have *no* requirement that states that every XSD-valid document is a valid configuration, nor do we have a requirement that every valid configuration is XSD-valid; such a restriction would (in addition to breaking existing code) create unreasonable restrictions for us.

It comes down to the determination that the XSD we ship is better than shipping no XSD at all.

> WildFly Elytron Client Configuration File created based on elytron-1_0.xsd is not valid for clients
> ---------------------------------------------------------------------------------------------------
>
>                 Key: ELY-1098
>                 URL: https://issues.jboss.org/browse/ELY-1098
>             Project: WildFly Elytron
>          Issue Type: Bug
>    Affects Versions: 1.1.0.Beta34
>            Reporter: Ondrej Lukas
>            Assignee: Darran Lofthouse
>            Priority: Blocker
>
> There are some issues which causes that WildFly Elytron Client Configuration File created based on elytron-1_0.xsd is not valid for clients:
> * root element {{configuration}} is not included in elytron-1_0.xsd, it means that configuration with {{configuration}} are handled as invalid and configuration which has {{authentication-client}} as root element as valid
> * XSD elytron-1_0.xsd includes some elements on the highest level of XSD, which for example means that configuration file which includes only element {{<set-user-name name="someUser"/>}} is valid according to XSD.
> We request blocker because validated configuration file will not work correctly in clients. Moreover XSD is source of information which can be used by users for creating wildfly-config.xml correctly or validate their configuration file before using it. Mentioned issues can cause that this validation using elytron-1_0.xsd becomes unusable for users.



--
This message was sent by Atlassian JIRA
(v7.2.3#72005)


More information about the jboss-jira mailing list