[jboss-jira] [JBoss JIRA] (ELY-1085) CS tool, Help contains wrong description of "--create" option, there is description with true/false value.

[Hynek Švábek (JIRA)]

     [ https://issues.jboss.org/browse/ELY-1085?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Hynek Švábek updated ELY-1085:
------------------------------
    Description: 
Help contains wrong description of "--create" option, there is description with true/false value.
And now there is wrong behaviour too. I am able set some value (even invalid) for \--create option and it is valid.
I can set e.g. "--create false" and it pass. It is very confusing.

--create option doesn't expect any value.

Please make it consistent:
# "--create" is only flag -> please fix help usage and fix it in command (\--create false must be invalid)
# "--create" expects true/false value, in this case leave help usage unchanged



{code}
java -jar wildfly-elytron-tool.jar credential-store     --add secret_alias --password pass123 --secret secret_password --create false -f -l newstore.jceks
Alias "secret_alias" has been successfully stored
Credential store command summary:
--------------------------------------
/subsystem=elytron/credential-store=cs:add(relative-to=jboss.server.data.dir,location="newstore.jceks",create=true,implementation-properties={"keyStoreType"=>"JCEKS","create"=>"true","location"=>"newstore.jceks","modifiable"=>"true"},credential-reference={clear-text="pass123"})
{code}

{code}
java -jar  wildfly-elytron-tool.jar credential-store --help
...
 -c,--create                     Create credential store [true/false]
...
{code}

  was:
Help contains wrong description of "--create" option, there is description with true/false value.

--create option doesn't expect any value.

{code}
java -jar  wildfly-elytron-tool.jar credential-store --help
...
 -c,--create                     Create credential store [true/false]
...
{code}



> CS tool, Help contains wrong description of "--create" option, there is description with true/false value.
> ----------------------------------------------------------------------------------------------------------
>
>                 Key: ELY-1085
>                 URL: https://issues.jboss.org/browse/ELY-1085
>             Project: WildFly Elytron
>          Issue Type: Bug
>          Components: Credential Store
>            Reporter: Hynek Švábek
>            Assignee: Ilia Vassilev
>
> Help contains wrong description of "--create" option, there is description with true/false value.
> And now there is wrong behaviour too. I am able set some value (even invalid) for \--create option and it is valid.
> I can set e.g. "--create false" and it pass. It is very confusing.
> --create option doesn't expect any value.
> Please make it consistent:
> # "--create" is only flag -> please fix help usage and fix it in command (\--create false must be invalid)
> # "--create" expects true/false value, in this case leave help usage unchanged
> {code}
> java -jar wildfly-elytron-tool.jar credential-store     --add secret_alias --password pass123 --secret secret_password --create false -f -l newstore.jceks
> Alias "secret_alias" has been successfully stored
> Credential store command summary:
> --------------------------------------
> /subsystem=elytron/credential-store=cs:add(relative-to=jboss.server.data.dir,location="newstore.jceks",create=true,implementation-properties={"keyStoreType"=>"JCEKS","create"=>"true","location"=>"newstore.jceks","modifiable"=>"true"},credential-reference={clear-text="pass123"})
> {code}
> {code}
> java -jar  wildfly-elytron-tool.jar credential-store --help
> ...
>  -c,--create                     Create credential store [true/false]
> ...
> {code}



--
This message was sent by Atlassian JIRA
(v7.2.3#72005)